Allow config sources to be specified for containerd #1252
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
force-pushed
the
allow-config-source-to-be-overridden-backport
branch
from
a49a73f to
3341bab
Compare
By default container extracts the current config by running the `containerd config dump` command and if that fails we read the existing config file. This change allows ordering of these sources to be defined as we do for the nvidia-ctk runtime configure command. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
allow-config-source-to-be-overridden-backport
branch
from
3341bab to
8334dde
Compare
|
Not a maintainer but LGTM. I think this is an adequate fix for #1222 :) |
|
Closing this backport since a workaround exists that does not require any changes. |
|
Hey at @elezar , just saw that you closed this. Is there a plan to include this workaround or another more permanent fix in the next release? Also, any idea on when the release will happen? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default container extracts the current config by running the
containerd config dumpcommand and if that fails we read the existing config file.This change allows ordering of these sources to be defined as we do for the nvidia-ctk runtime configure command.
Backport of #1251
See #1222