feat(node-agent): Mokka Node Agent NVLink simulator - #750
Open
roma-glushko wants to merge 7 commits into
Open
Conversation
roma-glushko
force-pushed
the
node-agent-nvlink
branch
from
August 28, 2026 11:16
c67e3f8 to
1471f51
Compare
roma-glushko
marked this pull request as ready for review
August 28, 2026 11:32
roma-glushko
force-pushed
the
node-agent-nvlink
branch
from
August 28, 2026 11:33
1471f51 to
5baaa35
Compare
Greptile SummaryThe change moves ComputeDomain topology staging from the setup script into a dedicated node-agent NVLink simulator.
Reviews (4): Last reviewed commit: "Ported NVLink simulator" | Re-trigger Greptile |
Comment on lines
+55
to
+58
| if _, err := os.Stat(sourcePath); err != nil { | ||
| s.ready.Store(true) | ||
| return nil | ||
| } |
There was a problem hiding this comment.
When the topology source disappears after a successful stage,
Stage returns without removing the existing overlay, causing new NRI-injected workloads to receive obsolete clique IDs and cluster UUIDs. Remove the owned overlay when the source no longer exists, while propagating other os.Stat errors.
Suggested change
| if _, err := os.Stat(sourcePath); err != nil { | |
| s.ready.Store(true) | |
| return nil | |
| } | |
| if _, err := os.Stat(sourcePath); err != nil { | |
| if !os.IsNotExist(err) { | |
| return err | |
| } | |
| if err := h.Remove(h.RootPath(overlayRel)); err != nil { | |
| return err | |
| } | |
| s.ready.Store(true) | |
| return nil | |
| } |
Knowledge Base Used:
roma-glushko
force-pushed
the
node-agent-nvlink
branch
from
August 31, 2026 11:26
5baaa35 to
7e62408
Compare
Signed-off-by: Roman Hlushko <rhlushko@nvidia.com>
Signed-off-by: Roman Hlushko <rhlushko@nvidia.com>
- Porting InfiniBand simulator to Node Agent - Move IB shims to the shims dir - Move IB daemon code to `internal/ib/*` package - Add a set of path sugar methods to Host struct to simplify path building across simulators - Revisited bundle-ib-tools.sh script - Dropped mock-ib CLI - Dropped manual register peers mode used in tests in order to simplify the system - Implemented IB sysfs tree reconcilation - Moved common filesystem operations into `internal/fsutils` package This is an interim refactoring for IB. With Mokka Control Plane, most of the IB daemon code can be delegated to the Control Plane. --------- Signed-off-by: Roman Hlushko <rhlushko@nvidia.com> # Conflicts: # cmd/node-agent/main.go # deployments/nvml-mock/helm/nvml-mock/tests/__snapshot__/daemonset_test.yaml.snap # deployments/nvml-mock/scripts/setup.sh # enhancements/meps/0003-node-agent/README.md
Signed-off-by: Roman Hlushko <rhlushko@nvidia.com>
Signed-off-by: Roman Hlushko <rhlushko@nvidia.com>
roma-glushko
force-pushed
the
node-agent-nvlink
branch
from
August 31, 2026 12:32
7e62408 to
bc36da7
Compare
Signed-off-by: Roman Hlushko <rhlushko@nvidia.com>
Signed-off-by: Roman Hlushko <rhlushko@nvidia.com>
roma-glushko
force-pushed
the
node-agent-nvlink
branch
from
August 31, 2026 14:14
bc36da7 to
ff71906
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This PR Does
Ported NVLink simulator.
Since it's just contains of moving one topology.yaml file under the proper location we may find a better place for this code potentially completely eliminating NVLink as a simulator. However, for now, for the sake of compliance with the existing logic, we keep it as a simulator.
Why
A part of MEP0003.
Checklist
git commit -s)go test -v -race ./...)make lint-fix)Stack created with GitHub Stacks CLI • Give Feedback 💬