Skip to content

refactor: Removed unused pkg/kubernetes package #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roma-glushko wants to merge 3 commits into from
Closed

refactor: Removed unused pkg/kubernetes package #732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3be1238
Removed dead weight code in pkg/kubernetes
roma-glushko Aug 25, 2026
d7f7e9f
Added changelog item
roma-glushko Aug 25, 2026
2c43d9d
make vendor cleanup
roma-glushko Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ so all consumers and applications up the stack work without modifications.
- Red-green test-driven development
- Code should communicate your intent
- Code should be composable and testable
- No code is better than a dead weight left just in case
- Major features or refactorings should be proposed via [MEPs](./enhancements).

## Scale

Expand All @@ -40,3 +42,4 @@ so all consumers and applications up the stack work without modifications.

- When leaving a comment in code, it should explain intent where it's not obvious — why we are doing something, not what we are doing, in most cases. Don't write comments based on the current conversation context; they should generally be valuable long-term for readers.
- Any documentation you produce must be concise and straight to the point.
- Every PR should add a concise, external user-facing changelog item to [CHANGELOG.md](./CHANGELOG.md)
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
unaffected. The chart schema permits unknown keys, so a values file still
setting `imex.enabled: true` installs silently with no state directory
mounted rather than failing. (#304)
- `pkg/kubernetes`. Its Ginkgo-bound node, taint, Job and cleanup helpers had no
in-tree callers; the e2e suite uses `tests/e2e/go/framework`. (#TBD)

### Fixed
- mocknvml: Xid critical-error events are now attributed to the whole GPU the
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ require (
k8s.io/klog/v2 v2.140.0
k8s.io/kubelet v0.36.3
sigs.k8s.io/node-feature-discovery v0.19.0
sigs.k8s.io/node-feature-discovery/api/nfd v0.19.0
sigs.k8s.io/yaml v1.6.0
)

Expand Down Expand Up @@ -69,6 +68,7 @@ require (
k8s.io/kube-openapi v0.0.0-20260317180543-43fb72c5454a // indirect
k8s.io/utils v0.0.0-20260210185600-b8788abfbbc2 // indirect
sigs.k8s.io/json v0.0.0-20250730193827-2d320260d730 // indirect
sigs.k8s.io/node-feature-discovery/api/nfd v0.19.0 // indirect
sigs.k8s.io/randfill v1.0.0 // indirect
sigs.k8s.io/structured-merge-diff/v6 v6.4.0 // indirect
)
75 changes: 0 additions & 75 deletions pkg/kubernetes/job.go
View file
Open in desktop

This file was deleted.

268 changes: 0 additions & 268 deletions pkg/kubernetes/kubernetes.go
View file
Open in desktop

This file was deleted.

Loading