Skip to content

Conversation

@shengnuo
Copy link
Collaborator

@shengnuo shengnuo commented Sep 11, 2025

This MR adds integrates NIMServices with GRPCRoute.

  • GRPCRoutes can be enabled via .spec.router.gateway.grpcRoutesEnabled
  router:
    gateway:
      namespace: nemo
      name: istio-gateway
      grpcRoutesEnabled: true
    hostDomainName: demo.nvidia.example.com
  • GRPC Port is specified under .spec.expose.service.grpcPort. If it's not specified, the default 50051 port is used.
  • If HTTPRoute is enabled along with GRPCRoute, then HTTPRoute and GRPCRoute objects will be created with the same hostname specified under .spec.router.hostname

Sample Istio Gateway (HTTP + gRPC on same hostname)

apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
metadata:
  name: istio-gateway
  namespace: nemo
spec:
  gatewayClassName: istio
  listeners:
  - allowedRoutes:
      namespaces:
        from: All
      kinds:
      - kind: HTTPRoute
    hostname: riva-tts.nemo.demo.nvidia.example.com
    name: http
    port: 80
    protocol: HTTP
  - allowedRoutes:
      namespaces:
        from: All
      kinds:
      - kind: GRPCRoute
    hostname: riva-tts.nemo.demo.nvidia.example.com
    name: grpc
    port: 50051
    protocol: HTTP

@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 11, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@shengnuo shengnuo force-pushed the grpcRoutes branch 4 times, most recently from 0980c4a to 60b4806 Compare September 16, 2025 19:07
@shengnuo shengnuo marked this pull request as ready for review September 16, 2025 20:09
…messages when router is enabled but the exposed service is of type LoadBalancer

Signed-off-by: Sheng Lin <[email protected]>
@shengnuo shengnuo force-pushed the grpcRoutes branch 3 times, most recently from 3ce7469 to 4d5c504 Compare October 16, 2025 23:04
shivamerla
shivamerla previously approved these changes Oct 19, 2025
Copy link
Collaborator

@shivamerla shivamerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks @shengnuo Now API looks much better.

@shivamerla
Copy link
Collaborator

/ok to test 4d5c504

@shengnuo shengnuo marked this pull request as ready for review October 20, 2025 03:53
namespace: nemo
name: istio-gateway
grpcRoutesEnabled: true
hostDomainName: demo.nvidia.example.com
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hostDomainName: demo.nvidia.example.com
hostDomainName: demo.example.nvidia.com

@shivamerla
Copy link
Collaborator

/ok to test 599b83e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants