Skip to content

Conversation

@rajathagasthya
Copy link
Contributor

@rajathagasthya rajathagasthya commented Oct 21, 2025

This commit makes the following changes:

  1. Builds multiarch images for non-release commits/PRs, in addition to released versions.
  2. Runs the docker build for an arch on the respective GitHub runner (e.g. a linux/amd64 docker image will be built on a linux/amd64 runner). This native build reduces build times due to not requring emulation.
  3. Removes explicit use if buildx for docker build. Buildx is now the default builder in Docker. Also removes the related QEMU setup.

@rajathagasthya rajathagasthya force-pushed the native-docker-builds branch 3 times, most recently from 00a1898 to 2665f5f Compare October 21, 2025 18:43
@rajathagasthya rajathagasthya marked this pull request as ready for review October 21, 2025 18:44
@rajathagasthya rajathagasthya marked this pull request as draft October 21, 2025 18:44
@tariq1890
Copy link
Contributor

/ok to test 2665f5f

@rajathagasthya rajathagasthya force-pushed the native-docker-builds branch 2 times, most recently from 71bdb75 to 0e40f7f Compare October 21, 2025 19:18
@rajathagasthya rajathagasthya marked this pull request as ready for review October 21, 2025 20:10
Copy link
Contributor

@tariq1890 tariq1890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @rajathagasthya !

Let's get @elezar's review before merging

@rajathagasthya rajathagasthya force-pushed the native-docker-builds branch 2 times, most recently from 004e511 to 9e6896c Compare October 23, 2025 15:02
This commit makes the following changes:

1. Builds multiarch images for non-release commits/PRs, in addition to
   released versions.
2. Runs the docker build for an arch on the respective GitHub runner
   (e.g. a linux/amd64 docker image will be built on a linux/amd64
   runner). This native build reduces build times due to not requiring
   emulation.
3. Removes explicit use if buildx for docker build. Buildx is now the
   default builder in Docker. Also removes the related QEMU setup.

Signed-off-by: Rajath Agasthya <[email protected]>
@coderabbitai
Copy link

coderabbitai bot commented Oct 23, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch native-docker-builds

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@cdesiniotis cdesiniotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rajathagasthya!

@cdesiniotis cdesiniotis merged commit 1bdf2f6 into main Oct 27, 2025
12 checks passed
@cdesiniotis cdesiniotis deleted the native-docker-builds branch October 27, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants