Add support for explicitly enabling XIDs in health checks #1443
+265
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
force-pushed
the
robertdavidsmith/main
branch
from
30748c2 to
268ec6e
Compare
This change adds support for users to explicitly set specific XIDs as fatal errors that cause a device to be marked as unhealth. When used in conjunction with the ability to ignore ALL XIDs, the set of XIDs that are fatal can be set. To do this, an environment variable DP_ENABLE_HEALTHCHECKS that mirrors the existing DP_DISABLE_HEALTHCHECKS envvar is added. Explicitly enabling an XID overrides disabling them. Signed-off-by: Robert Smith <[email protected]> Co-Authored-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
robertdavidsmith/main
branch
from
268ec6e to
0900fac
Compare
ArangoGutierrez
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for users to explicitly set specific XIDs as fatal errors that cause a device to be marked as unhealth. When used in conjunction with the ability to ignore ALL XIDs, the set of XIDs that are fatal can be set.
To do this, an environment variable DP_ENABLE_HEALTHCHECKS that mirrors the existing DP_DISABLE_HEALTHCHECKS envvar is added.
Explicitly enabling an XID overrides disabling them.
This builds on the change from #1335