Skip to content

feat(rest-api): support forced machine deletion - #5394

Draft
kfelternv wants to merge 10 commits into
NVIDIA:mainfrom
kfelternv:feat-mcp-mutations
Draft

feat(rest-api): support forced machine deletion#5394
kfelternv wants to merge 10 commits into
NVIDIA:mainfrom
kfelternv:feat-mcp-mutations

Conversation

@kfelternv

Copy link
Copy Markdown
Contributor

Provider administrators need an explicit REST override when ordinary Machine deletion is blocked by connected resources. This adds force=true to Machine deletion, calls the Core force-delete path with the attached-Instance override, and returns structured results and API errors.

Related issues

None.

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

Focused REST handler and response-model tests pass. The focused Core test requires a host with the tss2-sys native development package; this worker stopped before compiling the test binary because that package is unavailable locally.

@copy-pr-bot

copy-pr-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

@thossain-nv thossain-nv added the rest-api Add this label when an issue or PR concerns NICo REST API label Aug 26, 2026 — with ChatGPT Codex Connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rest-api Add this label when an issue or PR concerns NICo REST API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants