Skip to content

Reduce NEIGHBORS_ALL_NEIGHBORS_TEST combinatorial test space - #2573

Merged
rapids-bot[bot] merged 3 commits into
NVIDIA:mainfrom
robertmaynard:fea/improve_neighbors_test_time
Sep 12, 2026
Merged

Reduce NEIGHBORS_ALL_NEIGHBORS_TEST combinatorial test space#2573
rapids-bot[bot] merged 3 commits into
NVIDIA:mainfrom
robertmaynard:fea/improve_neighbors_test_time

Conversation

@robertmaynard

Copy link
Copy Markdown
Contributor

Moves NEIGHBORS_ALL_NEIGHBORS_TEST runtime from 34 minutes to 4 minutes by making the combinatorial space a little sparse.

Primarily this is done by doing:

  1. Data locality/movement testing doesn't need to happen across all n_row * dim * graph_degree inputs

  2. Make n_row * dim * graph_degree sparser for batched tests. This is done by testing min, max and ~diagonal for this test space.

Moves NEIGHBORS_ALL_NEIGHBORS_TEST runtime from 34 minutes
to 4 minutes by making the combinatorial space a little sparse.

Primarily this is done by doing:

1. Data locality/movement testing doesn't need to happen across
all n_row * dim * graph_degree inputs

2. Make n_row * dim * graph_degree sparser for batched tests. This
is done by testing min, max and ~diagonal for this test space.
@robertmaynard
robertmaynard requested a review from a team as a code owner September 9, 2026 15:28
@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change ci labels Sep 9, 2026

@tfeher tfeher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@cjnolet

cjnolet commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

/merge

@rapids-bot
rapids-bot Bot merged commit 77643f0 into NVIDIA:main Sep 12, 2026
186 of 189 checks passed
@robertmaynard
robertmaynard deleted the fea/improve_neighbors_test_time branch September 12, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci feature request New feature or request non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants