Add C++ API reference to Sphinx docs - #8544
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (3)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughChangesC++ API documentation
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change publishes generated C++ API namespace documentation through the Sphinx site. No concrete merge-blocking risk remains in the supplied change context. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (6 skipped: 6 unsupported.)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
We don't currently consider the C++ api public in any way - I'd worry about the effect of publishing the docs for something that we make no promise is usable outside of the python library (and no promises of deprecations/no breaking changes). Personally I wouldn't want these docs to be published at this point.
cc @csadorf for another opinion.
I'm also against promoting the C++ API within our documentation in this way at this point in time. I wouldn't describe it as "not public at all", but it's certainly not as stable as the Python API, we don't have a formalized deprecation policy at the moment, and we are making breaking changes whenever needed. It is my intention that we work towards improving and stabilizing the C++ API and eventually promote it as more stable, but at this point, I agree with @jcrist , I'm afraid it would set the wrong expectations. |
|
We currently publish C++ docs for libcuml. It is linked from https://docs.rapids.ai/api/#rapids-libraries and points to https://docs.rapids.ai/api/libcuml/nightly/. We are dropping publication of all our Doxygen sites to reduce maintenance cost. If you don't want Sphinx docs, that's fine, but we won't have Doxygen either. |
Summary
Integrate cuML’s Doxygen-generated C++ API into the Sphinx documentation using Breathe. This adds namespace references for
ML,MLCommon, andcuml::geneticto the main documentation navigation and normalizes Doxygen 1.9.1 XML constructs that Sphinx cannot represent.