-
Notifications
You must be signed in to change notification settings - Fork 662
Add cuml.metrics.precision_score #8524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VaggelisGian
wants to merge
7
commits into
NVIDIA:main
Choose a base branch
from
VaggelisGian:fea-cupy-precision-score
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+674
−3
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
84ad1fe
Add cuml.metrics.precision_score
VaggelisGian 30c290d
Cut precision_score peak memory from O(L^2) to O(n+L)
VaggelisGian 4787a76
Keep precision_score scalar scoring on the device
VaggelisGian 5c649d4
Flatten one-column metric inputs with reshape instead of squeeze
VaggelisGian 8c4b9c7
Score a missing pos_label as undefined for one-class targets
VaggelisGian 2b3881d
Accept any Real zero_division value equal to 0 or 1
VaggelisGian 5ba7874
Compare numpy scalar zero_division literals against cuml only
VaggelisGian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Validate numeric targets before the absent-positive early return.
If a one-class target contains a fractional, NaN, or infinite value and
pos_labelis absent, this branch returnszero_division_valuebefore lines 267-277 run. For example,precision_score([0.5], [0.5])returns 0 with a warning instead of raisingValueError. Move numeric-target validation before the binary-label branch, or validate before this return.As per coding guidelines,
python/**/*.pyrequires validation for invalid input (Missing validation causing crashes on invalid input).🤖 Prompt for AI Agents
Source: Coding guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The numeric validation already runs before this return: the loop that raises on NaN, infinity and fractional values executes unconditionally at the top of the numeric branch, above the absent-positive check, so a one-class fractional target raises before reaching it. Verified: precision_score([0.5], [0.5]) raises 'ValueError: y_true can only have integer values', matching scikit-learn's refusal of continuous targets ('continuous is not supported'). No reorder needed.