Update premerge guardwords - #1031
Merged
YanxuanLiu merged 1 commit intoAug 14, 2026
Merged
Conversation
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Collaborator
Author
|
build |
YanxuanLiu
marked this pull request as ready for review
August 13, 2026 06:27
YanxuanLiu
requested review from
GaryShen2008 and
yinqingh
and
a lite review from Copilot
August 13, 2026 06:27
Contributor
Greptile SummaryThe PR extends premerge failure-log filtering with Artifactory and Sonar hostname patterns.
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code failure identified. The added guardwords follow the existing hostname-pattern form, are valid regular expressions, and preserve the existing failure-log upload flow. Important Files Changed
Reviews (1): Last reviewed commit: "Update premerge guardwords" | Re-trigger Greptile |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Jenkins pre-merge pipeline log-upload redaction configuration by expanding the set of guardwords used to mask sensitive URLs/hosts when a build fails.
Changes:
- Add Artifactory and Sonar domain patterns to the
guardWordslist used for log redaction on failure. - Reformat the guardword list for readability.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+210
to
213
| def guardWords = ["gitlab.*?\\.com", "urm.*?\\.com", | ||
| "artifactory.*?\\.com", "sonar.*?\\.com", "sc-ipp-*"] | ||
| guardWords.add("nvidia-smi(?s)(.*?)(?=git)") // hide GPU info | ||
| guardWords.add("sc-ipp*") // hide cloud info |
NvTimLiu
approved these changes
Aug 13, 2026
rishic3
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update premerge guardwords