Skip to content

Update premerge guardwords - #1031

Merged
YanxuanLiu merged 1 commit into
NVIDIA:mainfrom
YanxuanLiu:agent/update-premerge-guardwords
Aug 14, 2026
Merged

Update premerge guardwords#1031
YanxuanLiu merged 1 commit into
NVIDIA:mainfrom
YanxuanLiu:agent/update-premerge-guardwords

Conversation

@YanxuanLiu

@YanxuanLiu YanxuanLiu commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Update premerge guardwords

Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
@YanxuanLiu YanxuanLiu self-assigned this Aug 13, 2026
@YanxuanLiu

Copy link
Copy Markdown
Collaborator Author

build

@YanxuanLiu
YanxuanLiu marked this pull request as ready for review August 13, 2026 06:27
@YanxuanLiu
YanxuanLiu requested review from GaryShen2008 and yinqingh and a lite review from Copilot August 13, 2026 06:27
@greptile-apps

greptile-apps Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR extends premerge failure-log filtering with Artifactory and Sonar hostname patterns.

  • Adds artifactory.*?\.com to the failure-log guardword list.
  • Adds sonar.*?\.com to the same list.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete changed-code failure identified.

The added guardwords follow the existing hostname-pattern form, are valid regular expressions, and preserve the existing failure-log upload flow.

Important Files Changed

Filename Overview
ci/Jenkinsfile.premerge Adds two syntactically valid hostname patterns to the guardword list used when uploading logs from failed premerge builds; no actionable defect was established.

Reviews (1): Last reviewed commit: "Update premerge guardwords" | Re-trigger Greptile

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Jenkins pre-merge pipeline log-upload redaction configuration by expanding the set of guardwords used to mask sensitive URLs/hosts when a build fails.

Changes:

  • Add Artifactory and Sonar domain patterns to the guardWords list used for log redaction on failure.
  • Reformat the guardword list for readability.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread ci/Jenkinsfile.premerge
Comment on lines +210 to 213
def guardWords = ["gitlab.*?\\.com", "urm.*?\\.com",
"artifactory.*?\\.com", "sonar.*?\\.com", "sc-ipp-*"]
guardWords.add("nvidia-smi(?s)(.*?)(?=git)") // hide GPU info
guardWords.add("sc-ipp*") // hide cloud info
@YanxuanLiu
YanxuanLiu merged commit 1539987 into NVIDIA:main Aug 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants