Fix deprecation warning: declaring default stream as cuda::stream_ref - #23865
Fix deprecation warning: declaring default stream as cuda::stream_ref#23865davidwendt wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe merge list and merge struct benchmarks now use ChangesMerge benchmark stream updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized benchmark-only change replaces deprecated default stream construction and does not introduce an actionable merge-blocking risk; it is merge-ready after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| void nvbench_merge_list(nvbench::state& state) | ||
| { | ||
| cuda::stream_ref stream; | ||
| auto stream = cudf::get_default_stream(); |
There was a problem hiding this comment.
We need to fix this so cudf::get_default_stream() returns a cuda::stream_ref. Otherwise we'll be going backwards in our efforts to move away from rmm::cuda_stream_view here.
There was a problem hiding this comment.
That seems like an ongoing change that would eventually fix this code. Can we merge this until then perhaps?
Description
Fixes a deprecation warning where
cudf::stream_refwas variable was declared without a stream.Introduced by #23769
Checklist