Skip to content

ci: validate notebook JSON - #330

Merged
lfengad merged 2 commits into
mainfrom
liangf/ci-validate-notebooks
Aug 25, 2026
Merged

ci: validate notebook JSON#330
lfengad merged 2 commits into
mainfrom
liangf/ci-validate-notebooks

Conversation

@lfengad

@lfengad lfengad commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • validate every tracked notebook as JSON on each pull request
  • rerun validation after notebook changes land on main
  • use only the standard GitHub-hosted runner and Python standard library

Testing

  • validated all 32 tracked notebooks on the latest main
  • confirmed the malformed notebook from Fix a comma issue #327 is rejected with a JSON parse error

Signed-off-by: liang.feng <liangf@nvidia.com>
@MaciejBalaNV

Copy link
Copy Markdown
Collaborator

Can we add a few more static checks, like nbformat.validate() or ruff?

Signed-off-by: liang.feng <liangf@nvidia.com>
@lfengad

lfengad commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator Author

@MaciejBalaNV Have added te ruff and format check. Thx.

@MaciejBalaNV MaciejBalaNV left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@lfengad
lfengad merged commit e7ad5e7 into main Aug 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants