Skip to content

[PyTorch] Avoid parameters function in op backward pass #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 22, 2025
Merged

[PyTorch] Avoid parameters function in op backward pass #1403

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce8f571
Avoid `parameters` function in op backward pass
timmoon10 Jan 11, 2025
2aa4cf1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 11, 2025
d10252f
Merge branch 'main' into te-sequential-param-count-bugfix
timmoon10 Jan 13, 2025
850500d
Merge branch 'main' into te-sequential-param-count-bugfix
timmoon10 Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions transformer_engine/pytorch/ops/fuser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ def forward(
func_ctx.backward_ops = backward_ops
func_ctx.basic_ops = basic_ops
func_ctx.basic_op_ctxs = basic_op_ctxs
func_ctx.num_params = num_params
func_ctx.basic_op_num_params = [sum(1 for _ in op.parameters()) for op in basic_ops]
func_ctx.num_extra_inputs = num_extra_inputs
func_ctx.num_extra_outputs = len(extra_outputs_flat)
func_ctx.is_first_module = FP8GlobalStateManager.is_first_fp8_module()
Expand Down Expand Up @@ -258,14 +258,14 @@ def backward(
# Flatten list of parameter gradients
grad_params_flat = []
for idx, dparams in enumerate(grad_params):
params = list(basic_ops[idx].parameters())
num_params = func_ctx.basic_op_num_params[idx]
if dparams is None:
dparams = [None for _ in range(len(params))]
dparams = [None for _ in range(num_params)]
else:
dparams = list(dparams)
if len(dparams) != len(params):
if len(dparams) != num_params:
raise RuntimeError(
f"Expected op {idx} to generate {len(params)} param grads, "
f"Expected op {idx} to generate {num_params} param grads, "
f"but got {len(dparams)}"
)
grad_params_flat.extend(dparams)
Expand Down
Loading