Skip to content

Conversation

joe0731
Copy link

@joe0731 joe0731 commented Oct 13, 2025

What does this PR do?

Type of change: ? add new tests

Overview: ?
add test coverage for the ONNX-PTQ examples part

Key Improvements:

  • comprehensive test coverage: added 5 new test suites covering different ONNX PTQ scenarios
  • better organization: split tests by functionality (LLM, timm, autocast, plugins, general)
  • reusable run_cmd: Created utility modules (onnx_path.py, enhanced run_command.py) for easier test development
  • TRT plugins parts: tests cover real-world use cases including custom TRT plugins and various model types
    .

Testing

export MODELOPT_LOCAL_MODEL_ROOT=/models/ && pytest tests/examples/onnx_ptq/ -vv -s -rA

Before your PR is "Ready for review"

  • Make sure you read and follow Contributor guidelines and your commits are signed.
  • Is this change backward compatible?: Yes/No
  • Did you write any new necessary tests?: Yes/No
  • Did you add or update any necessary documentation?: Yes/No
  • Did you update Changelog?: Yes/No

Additional Information

Copy link

copy-pr-bot bot commented Oct 13, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link

coderabbitai bot commented Oct 13, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Add skip_if_dtype_unsupported_by_arch() to automatically skip tests based on
GPU architecture capabilities. Supports Volta through Blackwell with various
quantization formats.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant