Skip to content

Conversation

@EmmaQiaoCh
Copy link
Collaborator

@EmmaQiaoCh EmmaQiaoCh commented Oct 30, 2025

Summary by CodeRabbit

  • Tests
    • Expanded GPU support in test configurations to include b300 and gb300 GPU patterns across multiple test suites, broadening hardware compatibility testing coverage.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@EmmaQiaoCh EmmaQiaoCh requested a review from a team as a code owner October 30, 2025 12:40
@EmmaQiaoCh
Copy link
Collaborator Author

/bot skip --comment "Cherry-pick the fix for B300/GB300 from main"

@EmmaQiaoCh EmmaQiaoCh enabled auto-merge (squash) October 30, 2025 12:42
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2025

📝 Walkthrough

Walkthrough

The PR extends GPU test coverage by adding wildcard patterns to four integration test configuration files. Specifically, *b300* is added to B300-related test configs and *gb300* is added to GB300-related test configs, expanding GPU matching criteria in existing wildcard lists.

Changes

Cohort / File(s) Change Summary
B300 GPU test configurations
tests/integration/test_lists/test-db/l0_b300.yml, tests/integration/test_lists/test-db/l0_dgx_b300.yml
Adds *b300* GPU wildcard pattern to existing *gb110* pattern in wildcards.gpu list
GB300 GPU test configurations
tests/integration/test_lists/test-db/l0_gb300.yml, tests/integration/test_lists/test-db/l0_gb300_multi_gpus.yml
Adds *gb300* GPU wildcard pattern to existing *gb110* pattern in wildcards.gpu list

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • All changes are homogeneous configuration updates with no logic modifications
  • Straightforward wildcard pattern additions across YAML files
  • No structural or conditional logic changes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description provided is largely incomplete. While the template structure is present, the critical sections required by the template are not filled out: the "Description" section contains only the instruction placeholder with no actual explanation of the issue or solution, and the "Test Coverage" section similarly lacks any details about what tests safeguard the changes. Although one checkbox item is marked in the PR Checklist, the author has not provided substantive information about what was verified or how the changes were tested. The PR requires actionable details to meet the repository's documentation standards.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "[TRTLLM-8971][infra] Cherry-pick for Update gpu key for B300/GB300 (#8724)" follows the prescribed template format with a valid JIRA ticket identifier, a valid type (infra), and a clear summary. The title accurately reflects the main changes in the pull request, which involve updating GPU wildcard patterns in four test configuration files to support B300 and GB300 GPUs. The title is specific, concise, and conveys the primary objective without unnecessary verbosity.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0dac57f and 4170bfd.

📒 Files selected for processing (4)
  • tests/integration/test_lists/test-db/l0_b300.yml (1 hunks)
  • tests/integration/test_lists/test-db/l0_dgx_b300.yml (1 hunks)
  • tests/integration/test_lists/test-db/l0_gb300.yml (1 hunks)
  • tests/integration/test_lists/test-db/l0_gb300_multi_gpus.yml (1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: pengbowang-nv
PR: NVIDIA/TensorRT-LLM#7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").
📚 Learning: 2025-08-26T09:49:04.956Z
Learnt from: pengbowang-nv
PR: NVIDIA/TensorRT-LLM#7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").

Applied to files:

  • tests/integration/test_lists/test-db/l0_gb300_multi_gpus.yml
  • tests/integration/test_lists/test-db/l0_dgx_b300.yml
  • tests/integration/test_lists/test-db/l0_gb300.yml
  • tests/integration/test_lists/test-db/l0_b300.yml
📚 Learning: 2025-09-09T09:40:45.658Z
Learnt from: fredricz-20070104
PR: NVIDIA/TensorRT-LLM#7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.

Applied to files:

  • tests/integration/test_lists/test-db/l0_gb300_multi_gpus.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (4)
tests/integration/test_lists/test-db/l0_dgx_b300.yml (1)

11-11: GPU wildcard expansion looks good.

The addition of *b300* to the gpu wildcards list follows the existing pattern and matches the file's purpose (B300 GPU tests). Per prior learnings, the test scheduling system correctly handles overlapping GPU wildcards and prevents duplicate test execution.

tests/integration/test_lists/test-db/l0_b300.yml (1)

11-11: Consistent GPU pattern addition across B300 configs.

This file adds the same *b300* pattern as l0_dgx_b300.yml. The duplication is intentional: this config targets single-GPU pre-merge tests, while l0_dgx_b300.yml targets multi-GPU post-merge tests. Both expand coverage for the B300 GPU family.

tests/integration/test_lists/test-db/l0_gb300_multi_gpus.yml (1)

11-11: GB300 pattern addition appropriate for multi-GPU ARM configuration.

The addition of *gb300* (note: GB300, not B300) correctly targets GB300 GPUs on ARM (aarch64) systems with 4-GPU configuration. This pattern matches the file's scope and is consistent with l0_gb300.yml.

tests/integration/test_lists/test-db/l0_gb300.yml (1)

11-11: Single-GPU GB300 pattern aligns with multi-GPU variant.

The *gb300* pattern addition mirrors the multi-GPU l0_gb300_multi_gpus.yml but scoped to single-GPU pre-merge tests on ARM systems. Consistent pattern naming and coverage strategy across both GB300 test files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23049 [ skip ] triggered by Bot. Commit: 4170bfd

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23049 [ skip ] completed with state SUCCESS. Commit: 4170bfd
Skipping testing for commit 4170bfd

@EmmaQiaoCh EmmaQiaoCh merged commit 9ee0075 into NVIDIA:release/1.1 Oct 30, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants