Skip to content

Conversation

@lkm2835
Copy link
Contributor

@lkm2835 lkm2835 commented Oct 28, 2025

…image build

Summary by CodeRabbit

  • Chores
    • Updated build configuration to include README documentation in the wheel distribution.

Description

This PR fixes a build error caused by this line during image build. (related to #8676)

with open("README.md", "r", encoding="utf-8") as fh:

2159.5   File "/usr/lib/python3/dist-packages/pyproject_hooks/_in_process/_in_process.py", line 251, in build_wheel
2159.5     return _build_backend().build_wheel(wheel_directory, config_settings,
2159.5            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2159.5   File "/usr/local/lib/python3.12/dist-packages/setuptools/build_meta.py", line 432, in build_wheel
2159.5     return _build(['bdist_wheel'])
2159.5            ^^^^^^^^^^^^^^^^^^^^^^^
2159.5   File "/usr/local/lib/python3.12/dist-packages/setuptools/build_meta.py", line 423, in _build
2159.5     return self._build_with_temp_dir(
2159.5            ^^^^^^^^^^^^^^^^^^^^^^^^^^
2159.5   File "/usr/local/lib/python3.12/dist-packages/setuptools/build_meta.py", line 404, in _build_with_temp_dir
2159.5     self.run_setup()
2159.5   File "/usr/local/lib/python3.12/dist-packages/setuptools/build_meta.py", line 512, in run_setup
2159.5     super().run_setup(setup_script=setup_script)
2159.5   File "/usr/local/lib/python3.12/dist-packages/setuptools/build_meta.py", line 317, in run_setup
2159.5     exec(code, locals())
2159.5   File "<string>", line 236, in <module>
2159.5 FileNotFoundError: [Errno 2] No such file or directory: 'README.md'

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@lkm2835 lkm2835 requested review from a team as code owners October 28, 2025 09:07
@svc-trtllm-gh-bot svc-trtllm-gh-bot added the Community want to contribute PRs initiated from Community label Oct 28, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2025

📝 Walkthrough

Walkthrough

A single line was added to the multi-stage Docker build configuration to copy README.md into the wheel stage root, ensuring the README file is included in the built wheel image.

Changes

Cohort / File(s) Summary
Docker build configuration
docker/Dockerfile.multi
Added COPY README.md ./ instruction in wheel stage to include README in built image

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "[None][fix] fix dockerfile: resolve installation issue caused by setup.py" follows the correct format specified in the template and is clearly related to the changeset. The title accurately identifies that this is a dockerfile fix addressing an installation issue triggered by setup.py, which aligns with the actual change of copying README.md into the dockerfile to resolve a FileNotFoundError. While the title could be more specific by explicitly mentioning README.md, it is sufficiently clear and specific to communicate the main purpose of the change to someone reviewing the commit history.
Description Check ✅ Passed The PR description provides a clear explanation of the issue and its context. The Description section effectively explains the build error (FileNotFoundError for 'README.md' during wheel building), references the related PR #8676, and includes a detailed error traceback that helps understand the problem. However, the Test Coverage section is left unfilled with only the template comment remaining, and most items in the PR Checklist are unchecked. While the core objective of explaining the issue and solution is met, the Test Coverage section represents a gap in documentation that should ideally specify how this change is validated.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community want to contribute PRs initiated from Community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants