Skip to content

Conversation

@VALLIS-NERIA
Copy link
Collaborator

@VALLIS-NERIA VALLIS-NERIA commented Oct 16, 2025

Summary by CodeRabbit

  • Documentation
    • Added tip blocks in Linux installation guides clarifying TensorRT LLM 1.1 CUDA compatibility.
    • Specified support for CUDA 12.9 and 13.0, noting that the wheel targets CUDA 12.9 and CUDA 13.0 is available via the NGC container.
    • Included guidance on adjusting requirements (uncomment/comment lines) for CUDA 12.9 during build.
    • Placed tips under prerequisites and Build TensorRT LLM sections to improve visibility.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@VALLIS-NERIA VALLIS-NERIA requested a review from a team as a code owner October 16, 2025 03:59
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 16, 2025

📝 Walkthrough

Walkthrough

Adds CUDA 12.9/13.0 compatibility tip blocks to Linux installation docs, including guidance that wheels target CUDA 12.9 and CUDA 13.0 is supported via NGC container, plus uncomment/comment instructions for CUDA 12.9 in build-from-source docs. No code or logic changes.

Changes

Cohort / File(s) Summary
Installation docs: CUDA compatibility tips
docs/source/installation/linux.md, docs/source/installation/build-from-source-linux.md
Insert tip blocks on TensorRT LLM 1.1 CUDA compatibility: support for CUDA 12.9 and 13.0; wheels target 12.9; 13.0 via NGC container. In build-from-source, add instructions to uncomment/comment requirements lines for CUDA 12.9. No functional changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • nv-guomingz
  • litaotju

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The provided PR description is only the unfilled template scaffold and does not include a proper title, a concise Description of the changes and rationale, or any Test Coverage details. It therefore lacks the essential information required by the repository’s description template to understand the purpose and impact of the changes. As a result, reviewers cannot adequately assess or test the modifications based on the current description. Please replace the placeholder comments with a filled PR title including the ticket and type, add a clear Description explaining what was changed and why, populate the Test Coverage section with relevant test references, and ensure all checklist items are addressed before merging.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title correctly includes the NVBugs reference, uses the “[doc]” type tag, and succinctly summarizes the inclusion of CUDA 12.9 documentation, which accurately reflects the changes made to the installation guides.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ZhanruiSunCh
Copy link
Collaborator

/bot run

@ZhanruiSunCh ZhanruiSunCh enabled auto-merge (squash) October 16, 2025 05:01
@tensorrt-cicd
Copy link
Collaborator

PR_Github #21524 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21524 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #16251 completed with status: 'FAILURE'

@VALLIS-NERIA
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21538 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21538 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #16259 completed with status: 'SUCCESS'

@ZhanruiSunCh ZhanruiSunCh merged commit 89d03d7 into NVIDIA:main Oct 16, 2025
7 of 9 checks passed
govind-ramnarayan pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Oct 21, 2025
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants