Skip to content

Conversation

VALLIS-NERIA
Copy link
Collaborator

@VALLIS-NERIA VALLIS-NERIA commented Oct 8, 2025

…A 12.9

Summary by CodeRabbit

  • Documentation
    • Clarified CUDA compatibility for TensorRT LLM 1.1: supports CUDA 12.9 and 13.0.
    • Noted that prebuilt wheels are available for CUDA 12.9; CUDA 13.0 is provided via the NGC container.
    • Added guidance for building from source with CUDA 12.9, including which requirement lines to comment/uncomment.
    • Confirmed no changes to build commands or logic.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@VALLIS-NERIA VALLIS-NERIA requested a review from a team as a code owner October 8, 2025 05:57
@VALLIS-NERIA VALLIS-NERIA changed the title [https://nvbugs/5532789] [doc] Add documents about dependency for CUD… [https://nvbugs/5532789] [doc] Add documents about CUDA 12.9 Oct 8, 2025
Copy link
Contributor

coderabbitai bot commented Oct 8, 2025

📝 Walkthrough

Walkthrough

Adds CUDA compatibility notes for TensorRT LLM to Linux installation docs, detailing CUDA 12.9 vs 13.0 support and guidance. Updates are documentation-only with no build command or logic changes.

Changes

Cohort / File(s) Summary
Docs: CUDA compatibility notes
docs/source/installation/build-from-source-linux.md, docs/source/installation/linux.md
Insert notes clarifying TensorRT LLM 1.1 support for CUDA 12.9 and 13.0. Specify that wheels target CUDA 12.9, CUDA 13.0 is available via NGC container, and provide instruction to toggle requirement lines for CUDA 12.9 when building from source.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description is largely unfilled and does not adhere to the repository’s template requirements: there is no title following the specified “[ticket][type] Summary” format, the Description and Test Coverage sections are empty placeholders, and the PR Checklist is left in default form with only one generic checkbox completed. As a result, the review cannot determine the rationale or scope of the changes and lacks information on how to validate or test them. This makes the description incomplete and off-topic relative to the expected structure. Please update the PR by adding a proper title in the “[ticket][type] Summary” format, filling in the Description section with a clear explanation of the changes and their motivation, providing relevant Test Coverage details, and completing the PR Checklist with any applicable items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title includes the NVBugs ID, the correct [doc] type tag, and a concise summary of adding documentation about CUDA 12.9, which directly reflects the primary change in the pull request and follows the repository’s title format guidelines.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 647080e and 05e4f06.

📒 Files selected for processing (2)
  • docs/source/installation/build-from-source-linux.md (1 hunks)
  • docs/source/installation/linux.md (1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-08-21T00:16:56.457Z
Learnt from: farshadghodsian
PR: NVIDIA/TensorRT-LLM#7101
File: docs/source/blogs/tech_blog/blog9_Deploying_GPT_OSS_on_TRTLLM.md:36-36
Timestamp: 2025-08-21T00:16:56.457Z
Learning: TensorRT-LLM container release tags in documentation should only reference published NGC container images. The README badge version may be ahead of the actual published container versions.

Applied to files:

  • docs/source/installation/linux.md
📚 Learning: 2025-08-01T15:14:45.673Z
Learnt from: yibinl-nvidia
PR: NVIDIA/TensorRT-LLM#6506
File: examples/models/core/mixtral/requirements.txt:3-3
Timestamp: 2025-08-01T15:14:45.673Z
Learning: In TensorRT-LLM, examples directory can have different dependency versions than the root requirements.txt file. Version conflicts between root and examples dependencies are acceptable because examples are designed to be standalone and self-contained.

Applied to files:

  • docs/source/installation/build-from-source-linux.md
📚 Learning: 2025-08-27T14:23:55.566Z
Learnt from: ixlmar
PR: NVIDIA/TensorRT-LLM#7294
File: tensorrt_llm/_torch/modules/rms_norm.py:17-17
Timestamp: 2025-08-27T14:23:55.566Z
Learning: The TensorRT-LLM project requires Python 3.10+ as evidenced by the use of TypeAlias from typing module, match/case statements, and union type | syntax throughout the codebase, despite some documentation still mentioning Python 3.8+.

Applied to files:

  • docs/source/installation/build-from-source-linux.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

Signed-off-by: Xiwen Yu <[email protected]>
@nv-guomingz
Copy link
Collaborator

/bot skip --comments "doc only change"

@nv-guomingz nv-guomingz enabled auto-merge (squash) October 13, 2025 06:51
@tensorrt-cicd
Copy link
Collaborator

PR_Github #21161 Bot args parsing error: usage: /bot skip --comment COMMENT
/bot skip: error: the following arguments are required: --comment

@VALLIS-NERIA
Copy link
Collaborator Author

/bot skip --comment "doc only change"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21166 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21166 [ skip ] completed with state SUCCESS
Skipping testing for commit e83234b

@nv-guomingz nv-guomingz merged commit 6545d54 into NVIDIA:release/1.1 Oct 13, 2025
5 checks passed
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Oct 13, 2025
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Oct 13, 2025
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Oct 14, 2025
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants