Skip to content

Conversation

xxi-nv
Copy link
Collaborator

@xxi-nv xxi-nv commented Oct 8, 2025

…ion explicitly due to code refactor

Summary by CodeRabbit

  • Tests
    • Enhanced Fused MoE test stability by performing post-load processing after loading model weights, ensuring correct initialization across FP8 all-to-all configurations.
    • Reduced flakiness and improved realism by aligning tests with production-like initialization steps.
    • Harmonized workflows across variants for consistent validation.
    • No changes to public APIs or runtime behavior.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

…ion explicitly due to code refactor

Signed-off-by: xxi <[email protected]>
@xxi-nv xxi-nv requested a review from a team as a code owner October 8, 2025 02:43
@xxi-nv xxi-nv requested a review from Barry-Delaney October 8, 2025 02:43
@xxi-nv
Copy link
Collaborator Author

xxi-nv commented Oct 8, 2025

/bot run

Copy link
Contributor

coderabbitai bot commented Oct 8, 2025

📝 Walkthrough

Walkthrough

Adds post-load processing in fused MoE unit tests by invoking post_load_weights() on models after load_weights() in two FP8 alltoall blockwise test paths, ensuring models perform required initialization before running assertions.

Changes

Cohort / File(s) Summary of Changes
Test updates: fused MoE post-load step
tests/unittest/_torch/modules/test_fused_moe.py
After loading weights, tests now call post_load_weights() for both the FP8 alltoall blockwise and blockwise wide-ep variants to run post-load initialization before executing the test logic.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Tester
  participant Model as FusedMoE Model
  participant Weights as Weights

  Tester->>Model: load_weights(Weights)
  note right of Model: Weights loaded into parameters
  Tester->>Model: post_load_weights()
  note right of Model: Post-load initialization/state setup
  Tester->>Model: forward(inputs)
  Model-->>Tester: outputs
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description still contains placeholder template instructions instead of an actual summary and leaves the Description and Test Coverage sections either empty or hidden within HTML comments, so essential context and test information are not visible. As a result, the description does not conform to the required template structure or provide sufficient detail about the change. Reviewers cannot quickly understand why the test was updated or how it is covered by existing or new tests. Remove the template comments and populate the summary section with a concise overview of the update, replace HTML comment blocks with visible content under Description outlining the background and solution, and list the relevant tests in the Test Coverage section. Ensure the PR Checklist items are completed as needed so the description fully conforms to the repository’s template and provides clear guidance for reviewers.
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The title references the NVBugs ticket, uses the correct fix type, and clearly summarizes the primary change to update the test case to explicitly call post-quantization following the refactor. It avoids unnecessary details and aligns with the repository’s title conventions by being concise and specific. Reviewers scanning the history will immediately understand the purpose of the change.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 647080e and 5ef582a.

📒 Files selected for processing (1)
  • tests/unittest/_torch/modules/test_fused_moe.py (2 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

  • tests/unittest/_torch/modules/test_fused_moe.py
**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

  • tests/unittest/_torch/modules/test_fused_moe.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

  • tests/unittest/_torch/modules/test_fused_moe.py
🧬 Code graph analysis (1)
tests/unittest/_torch/modules/test_fused_moe.py (9)
tensorrt_llm/_torch/modules/fused_moe/fused_moe_wide_ep.py (1)
  • post_load_weights (1040-1041)
tensorrt_llm/_torch/models/modeling_llama_min_latency.py (2)
  • post_load_weights (310-317)
  • post_load_weights (566-580)
tensorrt_llm/_torch/modules/fused_moe/fused_moe_cutlass.py (1)
  • post_load_weights (602-603)
tensorrt_llm/_torch/models/modeling_deepseekv3.py (1)
  • post_load_weights (1522-1549)
tensorrt_llm/_torch/modules/fused_moe/fused_moe_trtllm_gen.py (1)
  • post_load_weights (172-173)
tensorrt_llm/_torch/modules/fused_moe/interface.py (1)
  • post_load_weights (198-199)
tensorrt_llm/_torch/modules/fused_moe/fused_moe_triton.py (1)
  • post_load_weights (1389-1390)
tensorrt_llm/_torch/modules/linear.py (2)
  • post_load_weights (244-245)
  • post_load_weights (2008-2009)
tensorrt_llm/_torch/modules/fused_moe/quantization.py (2)
  • post_load_weights (325-326)
  • post_load_weights (732-752)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (2)
tests/unittest/_torch/modules/test_fused_moe.py (2)

743-743: LGTM! Post-load processing correctly added.

The addition of post_load_weights() after load_weights() is necessary for FP8_BLOCK_SCALES quantization on Blackwell GPUs to transform scaling factors into the required layout. This aligns with the pattern established in test_fused_moe_fp8_blockwise_deepgemm (line 888).


759-759: LGTM! Reference model also calling post-load processing.

Correctly ensures both the test model and reference model perform the same post-load weight transformations, maintaining test validity.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20759 [ run ] triggered by Bot

@xxi-nv xxi-nv enabled auto-merge (squash) October 8, 2025 02:59
@tensorrt-cicd
Copy link
Collaborator

PR_Github #20759 [ run ] completed with state SUCCESS
/LLM/release-1.1/L0_MergeRequest_PR pipeline #45 completed with status: 'SUCCESS'

@xxi-nv xxi-nv requested review from byshiue, kaiyux and litaotju and removed request for byshiue and litaotju October 9, 2025 00:12
@xxi-nv xxi-nv merged commit ea640a1 into NVIDIA:release/1.1 Oct 9, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants