Skip to content

Conversation

dongfengy
Copy link
Collaborator

@dongfengy dongfengy commented Oct 7, 2025

Summary by CodeRabbit

  • Tests
    • Re-enabled three previously skipped multi-GPU quantization scenarios for the PyTorch LLM API, covering expert, data, and tensor parallel modes.
    • These tests now run in CI, improving coverage and confidence in multi-GPU execution paths.
    • No changes to other skips; all remaining test waivers are unchanged.
    • No user-facing behavior changes; this is a test-only update.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@dongfengy dongfengy requested a review from xinhe-nv October 7, 2025 22:18
@dongfengy dongfengy force-pushed the user/dongfengy/gptoss-test-back branch from 71a4c0a to db9970e Compare October 7, 2025 22:19
@dongfengy
Copy link
Collaborator Author

/bot run

Copy link
Contributor

coderabbitai bot commented Oct 7, 2025

📝 Walkthrough

Walkthrough

Removed three SKIP entries from tests/integration/test_lists/waives.txt, enabling previously skipped multi-GPU tests in accuracy/test_llm_api_pytorch.py to run.

Changes

Cohort / File(s) Summary
Test waives updates
tests/integration/test_lists/waives.txt
Removed three SKIP entries for TestGPTOSS::test_w4_2gpus with ep2, dp2, and tp2 cutlass-auto variants; no other entries changed.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant CI as CI Pipeline
  participant Py as pytest
  participant WL as waives.txt
  participant TC as Test Collector

  CI->>Py: Run integration tests
  Py->>WL: Load SKIP list
  WL-->>Py: Provide waives (reduced set)
  Py->>TC: Collect tests
  alt Test previously waived
    note over Py,TC: Now enabled due to removed SKIP
    Py->>Py: Schedule test_w4_2gpus (ep2/dp2/tp2)
    Py->>CI: Execute enabled tests
  else Still waived tests
    Py->>Py: Skip remaining waived tests
  end
  Py-->>CI: Report results
Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description consists solely of the unmodified repository template with placeholder comments and lacks a filled‐in title, description, and test coverage information, so it does not conform to the required structure or provide any substantive details. Please replace the template placeholders with a proper PR title following the “[ticket][type] Summary” format, add a concise explanation of the issue and its fix in the Description section, list the relevant tests under Test Coverage, and verify all PR Checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title “[None][fix] Remove outdated test waives for GPTOSS” accurately and concisely describes the main change of removing outdated SKIP entries for GPTOSS tests and follows the required ticket/type format without extraneous details or noise.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20747 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20747 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15679 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@xinhe-nv xinhe-nv force-pushed the user/dongfengy/gptoss-test-back branch from db9970e to 6bb7f3c Compare October 9, 2025 01:20
@xinhe-nv xinhe-nv enabled auto-merge (squash) October 9, 2025 01:20
@dongfengy dongfengy force-pushed the user/dongfengy/gptoss-test-back branch from 6bb7f3c to cfb84bb Compare October 9, 2025 01:57
@dongfengy
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20836 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20836 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15756 completed with status: 'FAILURE'

@dongfengy dongfengy force-pushed the user/dongfengy/gptoss-test-back branch from cfb84bb to c75a5ea Compare October 9, 2025 16:36
@dongfengy
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20914 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20914 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15819 completed with status: 'FAILURE'

@dongfengy dongfengy force-pushed the user/dongfengy/gptoss-test-back branch from c75a5ea to 6f623d9 Compare October 9, 2025 19:10
@dongfengy
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20922 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20922 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15824 completed with status: 'FAILURE'

@dongfengy
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20928 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20928 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15830 completed with status: 'FAILURE'

@dongfengy dongfengy force-pushed the user/dongfengy/gptoss-test-back branch from 6f623d9 to 482ac06 Compare October 10, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants