[TRTLLM-7769][chore] document the role of 'd2t' #8174
Conversation
|
/bot run |
|
PR_Github #20725 [ run ] triggered by Bot |
ixlmar
force-pushed
the
chore/refactor-d2t
branch
from
63ac88c to
a1f626c
Compare
|
/bot run |
|
PR_Github #20728 [ run ] triggered by Bot |
|
PR_Github #20725 [ run ] completed with state |
|
PR_Github #20728 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #20736 [ run ] triggered by Bot |
|
PR_Github #20736 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
/bot kill |
|
PR_Github #20790 [ run ] triggered by Bot |
|
PR_Github #20791 [ kill ] triggered by Bot |
|
PR_Github #20790 [ run ] completed with state |
|
PR_Github #20791 [ kill ] completed with state |
ixlmar
force-pushed
the
chore/refactor-d2t
branch
from
a1f626c to
7c9c808
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #20792 [ run ] triggered by Bot |
|
PR_Github #20792 [ run ] completed with state |
ixlmar
force-pushed
the
chore/refactor-d2t
branch
from
7c9c808 to
f78c246
Compare
ixlmar
changed the title
|
/bot run --skip "no code changes" |
📝 WalkthroughWalkthroughAdded explanatory comments in tensorrt_llm/_torch/pyexecutor/sampler.py clarifying draft-to-target (d2t) token handling and vocab translation in batched sampling logic. Removed a previous FIXME, replacing it with detailed notes. Minor formatting cleanup (blank line removal) in sample_async. No functional or control-flow changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tensorrt_llm/_torch/pyexecutor/sampler.py (1)
1466-1474: LGTM! Thorough explanation of d2t vocab translation.The comment clearly explains the draft-to-target token transformation and its role in Eagle3 model handling. The discussion of design alternatives provides valuable context for why the current implementation handles d2t within the sampler.
Optional suggestion: Consider also documenting this design rationale in an ADR (Architecture Decision Record) or design document for long-term maintainability, as inline comments discussing implementation alternatives can become outdated as the codebase evolves.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tensorrt_llm/_torch/pyexecutor/sampler.py(2 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Use only spaces, no tabs; indent with 4 spaces.
Files:
tensorrt_llm/_torch/pyexecutor/sampler.py
**/*.py
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.
Files:
tensorrt_llm/_torch/pyexecutor/sampler.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).
Files:
tensorrt_llm/_torch/pyexecutor/sampler.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tensorrt_llm/_torch/pyexecutor/sampler.py (1)
1186-1191: LGTM! Clear explanation of sampler invocation patterns.The comment provides valuable context distinguishing between target and draft model invocations, which clarifies the variable token counts per request. This helps readers understand why the logic handles different scenarios.
|
PR_Github #20814 Bot args parsing error: usage: /bot [-h] |
|
/bot skip --comment "no code changes" |
|
PR_Github #20816 [ skip ] triggered by Bot |
|
PR_Github #20816 [ skip ] completed with state |
ixlmar
force-pushed
the
chore/refactor-d2t
branch
from
f78c246 to
021a557
Compare
|
/bot skip --comment "no code changes" |
|
PR_Github #20868 [ skip ] triggered by Bot |
|
PR_Github #20868 [ skip ] completed with state |
Signed-off-by: ixlmar <[email protected]>
ixlmar
force-pushed
the
chore/refactor-d2t
branch
from
021a557 to
81d28d9
Compare
|
/bot skip --comment "no code changes" |
|
PR_Github #20915 [ skip ] triggered by Bot |
|
PR_Github #20915 [ skip ] completed with state |
Description
This documents how 'd2t' interacts with sampling and drafting (including Eagle3 model forwards).
Test Coverage
No functional changes.
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.
Summary by CodeRabbit
No user-facing functionality changes; this update improves maintainability and clarity for future development.