feat: Add Mixture of Experts FP8xMXFP4 support #4750
+735
−459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djns99
force-pushed
the
user/dastokes/mxfp4_moe_support
branch
from
5b440c5 to
42993b6
Compare
|
/bot run |
djns99
requested review from
jinyangyuan-nvidia
and removed request for
liji-nv and
dongxuy04
|
PR_Github #6867 [ run ] triggered by Bot |
|
PR_Github #6867 [ run ] completed with state |
djns99
force-pushed
the
user/dastokes/mxfp4_moe_support
branch
2 times, most recently
from
de5981d to
aa4e98f
Compare
|
/bot run |
|
PR_Github #6964 [ run ] triggered by Bot |
djns99
force-pushed
the
user/dastokes/mxfp4_moe_support
branch
from
aa4e98f to
b19233c
Compare
Signed-off-by: Daniel Stokes <[email protected]>
djns99
force-pushed
the
user/dastokes/mxfp4_moe_support
branch
from
b19233c to
3945647
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #7010 [ run ] triggered by Bot |
|
PR_Github #6964 [ run ] completed with state |
liji-nv
reviewed
May 30, 2025
| @@ -1521,7 +1521,7 @@ def forward_chunk( | |||
| ep_rank=ep_rank, | |||
| cluster_size=cluster_size, | |||
| cluster_rank=cluster_rank, | |||
| use_fp8_block_scaling=use_fp8_block_scaling, | |||
| use_deepseek_fp8_block_scale=use_deepseek_fp8_block_scale, | |||
There was a problem hiding this comment.
Need a better naming rather than make it deepseek specific.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR title
Description
This PR adds support for using FP8 x MXFP4 on Blackwell to the Mixture of Experts plugin.
This is exposed through the C++ API, but not integrated into any torch flow
Test Coverage
mixtureOfExpertsTests.cu
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.