Skip to content

chore: fix llm_root when LLM_ROOT is not set #4741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

achartier
Copy link
Collaborator

PR title

chore: fix llm_root when LLM_ROOT is not set

Description

The current version has llm_root pointing to the tests directory which is incorrect as used in resource_path which expects the root directory to find cpp/tests/resources

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@achartier achartier requested a review from Funatiq May 28, 2025 20:16
@achartier
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6804 [ run ] triggered by Bot

@Funatiq Funatiq requested a review from DomBrown May 28, 2025 20:37
@tensorrt-cicd
Copy link
Collaborator

PR_Github #6804 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4959 completed with status: 'FAILURE'

@achartier
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6818 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6818 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4965 completed with status: 'FAILURE'

@achartier
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6861 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6861 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4990 completed with status: 'FAILURE'

@achartier
Copy link
Collaborator Author

/bot run

@achartier
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6956 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6956 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #5048 completed with status: 'FAILURE'

@achartier
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6966 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6966 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5055 completed with status: 'SUCCESS'

@achartier achartier merged commit 36b87b8 into NVIDIA:main May 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants