Repository navigation
[TRTLLM-17121][fix] Sync output-slice review fixes to Helix aggregate - #21238
Merged
zhaoyuanh-nvidia merged 1 commit intoOct 29, 2026
Conversation
Signed-off-by: Zhaoyuan He <195028209+zhaoyuanh-nvidia@users.noreply.github.com>
zhaoyuanh-nvidia
requested review from
JunyiXu-nv,
PerkzZheng,
heyuhhh and
zhaoyangwang-nvidia
October 29, 2026 04:20
zhaoyuanh-nvidia
requested review from
BowenFu,
EmmaQiaoCh,
QiJune and
mlefeb01
October 29, 2026 04:20
zhaoyuanh-nvidia
added a commit
to zhaoyuanh-nvidia/TensorRT-LLM
that referenced
this pull request
Oct 29, 2026
Refresh the main synchronization on the squash-merged review fixes from NVIDIA#21238. Preserve feature history and main ancestry, retain the validated Helix conflict resolutions, and integrate the latest upstream attention-test-list updates. Signed-off-by: Zhaoyuan He <195028209+zhaoyuanh-nvidia@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bring the remaining compatible review fixes from merged #20833 into
feat/helix-agg, whose original phase-dependent MLA port landed in #20920. This PR is intentionally limited to four files; it does not synchronizemainor rewrite the shared feature branch.The two low-M dispatch tests from #20833 depend on APIs not yet present on this feature branch. They belong with the separate
mainsynchronization, not with this narrow backport. Later feature work is unchanged.Test Coverage
Linearconstruction; it is not a native TensorRT-LLM pytest or GPU run.git diff --checkpassed.Integration
One DCO-signed-off commit, targeting
feat/helix-agg. Merge this narrow fix before the separatemainsynchronization PR #21240. That follow-up preserves upstream ancestry with a merge commit rather than rewriting the shared feature branch. No automatic merge requested.