[None][fix] revert git pin in 8f04d3a by tburt-nv · Pull Request #21128 · NVIDIA/TensorRT-LLM

tburt-nv · 2026-10-27T19:08:50Z

Description

As part of mass-merge PR #20232, commit 8f04d3a introduced a direct URL reference to the TRT-LLM wheel's dependencies, which makes it unreleaseable. This PR reverts that change so that we can release the wheel again.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Dev Engineer Review

The pinned LMBenchmark Git dependency is removed from requirements-dev.txt. The integration test installs the pinned dependency in its module fixture instead, avoiding that direct Git reference in the development requirements used for wheel release.
The test now reports a missing-package error after fixture setup. No test execution results were provided.

QA Engineer Review

The prefix-aware scheduling integration test changed. Existing test cases remain listed in CI test lists and the manual-QA list.
Coverage verdict: needs follow-up. The test is listed, but no execution results confirm that fixture installation and the benchmark validation pass.

Per-File QA Perspective

requirements-dev.txt: Removing the Git dependency changes the development dependency set. Verify that wheel release requirements no longer resolve this dependency.
tests/integration/defs/kv_cache/test_prefix_aware_scheduling.py: The module fixture installs LMBenchmark before resolving and validating its benchmark script. The test is listed in l0_b200.yml and l0_h100.yml, and in qa/llm_function_core.txt; the B300 smoke case is waived.

Signed-off-by: Tyler Burt <195370667+tburt-nv@users.noreply.github.com>

tburt-nv · 2026-10-27T19:09:18Z

/bot run --disable-fail-fast

coderabbitai · 2026-10-27T19:14:43Z

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: NVIDIA/TensorRT-LLM
Branch: main
File: .coderabbit.yaml
Commit: 0a03c3e
Layers: Repository YAML
Review profile: CHILL
Plan: Enterprise
Run ID: 2244b166-b423-4d83-bb90-02dbc82031fd

Commits

Reviewing files that changed from the base of the PR and between 0a03c3e and c55d5b1.

Files selected for processing: 2

requirements-dev.txt
tests/integration/defs/kv_cache/test_prefix_aware_scheduling.py

Files with no reviewable changes: 1

requirements-dev.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The pinned LMBenchmark Git dependency was removed from requirements-dev.txt and added to the prefix-aware scheduling test fixture. The test’s missing-package message and QPS-sweep docstring were also updated.

Changes

Benchmark provisioning

Layer / File(s)	Summary
Install LMBenchmark in the test fixture `requirements-dev.txt`, `tests/integration/defs/kv_cache/test_prefix_aware_scheduling.py`	The shared development requirements no longer include LMBenchmark. The test fixture installs the pinned package before resolving its script. The missing-package message and QPS-sweep docstring were updated.

Priority: High

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Possibly related PRs

NVIDIA/TensorRT-LLM#20584: Changes CI test-list collection to install requirements-dev.txt, which this PR updates.
NVIDIA/TensorRT-LLM#21087: Changes how check_test_list.py installs requirements-dev.txt, which this PR updates.

Suggested reviewers: yuanjingx87, xinhe-nv

Merge Risk: Minimal · up to c55d5

The dependency provisioning change is consistent with the release objective and is mergeable.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title "[None][fix] revert git pin in `8f04d3a`" follows the required template with a ticket tag, a type, and a summary. It names the main change, which removes the git pin that the commit `8f04d3a` ad…
Description check		The description explains the problem and the fix. The commit `8f04d3a` added a direct URL reference to the TRT-LLM wheel's dependencies, which blocks the release, and this PR reverts it. The description…
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "[None][fix] revert git pin in 8f04d3a" follows the required template with a ticket tag, a type, and a summary. It names the main change, which removes the git pin that the commit 8f04d3a added. The title is specific, but it uses the short commit hash without context, so a reader must check the commit to learn what the pin was.

Full details: Description check

Explanation

The description explains the problem and the fix. The commit 8f04d3a added a direct URL reference to the TRT-LLM wheel's dependencies, which blocks the release, and this PR reverts it. The description lacks a Test Coverage entry; the template comment is still present and no tests are listed. The PR checklist is marked as checked. The description does not state the intended effect on the test file or the requirements file, but the revert scope is clear from the summary.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 3 functions across 1 files.

Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

tensorrt-cicd · 2026-10-27T19:17:12Z

PR_Github #80957 [ run ] triggered by Bot. Commit: c55d5b1 Link to invocation

tensorrt-cicd · 2026-10-27T23:36:49Z

PR_Github #80957 [ run ] completed with state SUCCESS. Commit: c55d5b1
/LLM/main/L0_MergeRequest_PR pipeline #66679 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Signed-off-by: Tyler Burt <195370667+tburt-nv@users.noreply.github.com> (cherry picked from commit c55d5b1) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

chzblych · 2026-10-28T10:40:19Z

    global LMBENCHMARK_SCRIPT

+    llm_venv.run_cmd(["-m", "pip", "install", _LMBENCHMARK_INSTALL_SPEC], timeout=600)


@tburt-nv Could we add retries around this install to tolerate transient network failures during Git checkout or dependency installation? The existing timeout already handles stalled installs; a small retry would help with temporary failures that exit early.

github-actions · 2026-10-28T10:40:56Z

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

brnguyen2

Approving — the comments below are optional touch-ups, not blockers.

This restores the pre-#20232 LMBenchmark handling exactly, and leaves the unrelated grace_s change from that merge in place. The reason checks out: setup.py:160 reads requirements-dev.txt into the devel extra, so the benchmark @ git+... line ended up as a direct-URL dependency in the wheel metadata.

The git install now runs at fixture time, so these l0 tests depend on GitHub being reachable from CI again, same as before #20232. That is fine for now. If the owners want the pin back in a requirements file later, it needs to go in one that setup.py doesn't read.

brnguyen2 · 2026-10-28T18:20:00Z


-        This is a correctness stress test; request latency is reported but is
-        not a pass/fail threshold.
+        NOTE: This test is intended for post-merge / nightly CI due to its


This revert brings back the "intended for post-merge / nightly CI" note, but test_multi_round_qa_shared_prefix[*] is listed in pre-merge l0_h100.yml (lines 235-242). Consider keeping the newer "correctness stress test; latency is not a pass/fail threshold" wording so the docstring doesn't contradict the test lists.

revert 8f04d3a

c55d5b1

Signed-off-by: Tyler Burt <195370667+tburt-nv@users.noreply.github.com>

tburt-nv requested review from a team as code owners October 27, 2026 19:08

tburt-nv requested review from BowenFu, EmmaQiaoCh, brnguyen2, mlefeb01 and xinhe-nv October 27, 2026 19:08

github-actions Bot assigned tburt-nv Oct 27, 2026

BowenFu approved these changes Oct 28, 2026

View reviewed changes

xinhe-nv approved these changes Oct 28, 2026

View reviewed changes

chzblych pushed a commit that referenced this pull request Oct 28, 2026

[None][fix] revert git pin in 8f04d3a (#21128)

a5e63ec

Signed-off-by: Tyler Burt <195370667+tburt-nv@users.noreply.github.com> (cherry picked from commit c55d5b1) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

niukuo approved these changes Oct 28, 2026

View reviewed changes

chzblych approved these changes Oct 28, 2026

View reviewed changes

trtllm-agent added the ci: full pre-merge approved label Oct 28, 2026

brnguyen2 approved these changes Oct 28, 2026

View reviewed changes

Navigation Menu

Repository navigation

[None][fix] revert git pin in 8f04d3a - #21128

[None][fix] revert git pin in 8f04d3a#21128
tburt-nv wants to merge 1 commit into
NVIDIA:mainfrom
tburt-nv:user/tburt/revert_pin

tburt-nv commented Oct 27, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

tburt-nv commented Oct 27, 2026

Uh oh!

coderabbitai Bot commented Oct 27, 2026

Uh oh!

tensorrt-cicd commented Oct 27, 2026

Uh oh!

tensorrt-cicd commented Oct 27, 2026

Uh oh!

chzblych Oct 28, 2026

Uh oh!

github-actions Bot commented Oct 28, 2026

Uh oh!

brnguyen2 left a comment

Uh oh!

brnguyen2 Oct 28, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

		global LMBENCHMARK_SCRIPT

		llm_venv.run_cmd(["-m", "pip", "install", _LMBENCHMARK_INSTALL_SPEC], timeout=600)

Conversation

tburt-nv commented Oct 27, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test Coverage

PR Checklist

GitHub Bot Help

Dev Engineer Review

QA Engineer Review

Per-File QA Perspective

Uh oh!

tburt-nv commented Oct 27, 2026

Uh oh!

coderabbitai Bot commented Oct 27, 2026

Walkthrough

Changes

Uh oh!

tensorrt-cicd commented Oct 27, 2026

Uh oh!

tensorrt-cicd commented Oct 27, 2026

Uh oh!

chzblych Oct 28, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 28, 2026

Uh oh!

brnguyen2 left a comment

Choose a reason for hiding this comment

Uh oh!

brnguyen2 Oct 28, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

tburt-nv commented Oct 27, 2026 •

edited by coderabbitai Bot

Loading