Skip to content

[None][infra] Add blossom-ci authorized users - #20885

Merged
hanjingtian merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:auto/blossom-ci-add-users-20261023T073921
Oct 23, 2026
Merged

hanjingtian merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:auto/blossom-ci-add-users-20261023T073921

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Auto-generated by blossom-ci-onboard-bot from the CI-onboarding sheet.

Adds the following user(s) to the Blossom-CI trigger allowlist:

  • yt0428
  • ConstBob
  • Evan-Chern
  • krishung5

Dev Engineer Review

.github/workflows/blossom-ci.yml adds yt0428, ConstBob, Evan-Chern, and krishung5 to the Blossom-CI authorized-actor list. The change expands who can trigger Blossom-CI through the authorized comment command. Review findings were not supplied.

QA Engineer Review

No test changes.

Per-File QA Perspective

  • .github/workflows/blossom-ci.yml: The authorization workflow now accepts four additional usernames. Verify that each intended user can trigger Blossom-CI and that users outside the allowlist remain blocked.

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 12af626 and 20b4c65.

📒 Files selected for processing: 1
  • .github/workflows/blossom-ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The Blossom-CI workflow adds four usernames to the authorized-actor lists used for comment-command authorization.

Changes

Blossom-CI authorization

Layer / File(s) Summary
Add authorized actors
.github/workflows/blossom-ci.yml
The authorization lists now include ConstBob, Evan-Chern, krishung5, and yt0428.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 20b4c

The authorization updates match the stated intent and present no merge-blocking risk.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description clearly lists the users added to the Blossom-CI allowlist, but it does not use the required Description and Test Coverage sections or address the PR checklist. Add the required Description and Test Coverage sections. Explain the change and why it is needed, state the applicable validation or why testing is not required, and complete the PR checklist.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly identifies the infrastructure change and follows the required [None][infra] format.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

@hanjingtian

Copy link
Copy Markdown
Collaborator

/bot skip --comment "Add blossom-ci authorized users"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #80110 [ skip ] triggered by Bot. Commit: 20b4c65 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #80110 [ skip ] completed with state SUCCESS. Commit: 20b4c65
Skipping testing for commit 20b4c65

Link to invocation

@hanjingtian
hanjingtian merged commit c1e5bf2 into NVIDIA:main Oct 23, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants