Skip to content

[None][infra] Waive 1 failed cases for main in pre-merge 64813 - #20563

Merged
lori-ren merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20261019-032527
Oct 19, 2026
Merged

lori-ren merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20261019-032527

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @lori-ren)
Target branch: main
Bug(s): 6939212

Waive entries added

unittest/_torch/attention --ignore=unittest/_torch/attention/sparse/test_cute_dsl_gvr_topk_decode.py --ignore=unittest/_torch/attention/sparse/msa/test_minimax_m3_sparse_attn_decode.py SKIP (https://nvbugs/6939212)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Dev Engineer Review

The change adds a targeted SKIP waiver for unittest/_torch/attention. It excludes test_cute_dsl_gvr_topk_decode.py and test_minimax_m3_sparse_attn_decode.py and links the waiver to NVBug 6939212. The change is limited to the test list.

QA Engineer Review

The test-list change waives the two named attention test files. This reduces CI coverage for those cases while the waiver applies. Coverage verdict: needs follow-up.

Per-File QA Perspective

  • tests/integration/test_lists/waives.txt: Adds the attention waiver and its two exclusions. QA should verify the waiver scope and remove it when no longer needed.

Bug(s): 6939212
Requested by: @lori-ren

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@lori-ren

Copy link
Copy Markdown
Contributor

/bot skip --comment "Waive only PR"

@github-actions

Copy link
Copy Markdown

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/TensorRT-LLM/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 84b402a4-e1b1-4fe8-aa8c-edcee5eaf212
📥 Commits

Reviewing files that changed from the base of the PR and between d4624cb and b5b16cf.

📒 Files selected for processing: 1
  • tests/integration/test_lists/waives.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The waive list adds a SKIP entry for two sparse-attention test files under unittest/_torch/attention, tracked by NVBug 6939212.

Changes

Attention test waiver

Layer / File(s) Summary
Add sparse-attention test exclusions
tests/integration/test_lists/waives.txt
Adds a SKIP entry for unittest/_torch/attention, excluding sparse/test_cute_dsl_gvr_topk_decode.py and sparse/msa/test_minimax_m3_sparse_attn_decode.py. The entry references NVBug 6939212.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: yihuilu512

Merge Risk: ⚪ Minimal · up to b5b16

This change waives one known-failing attention test selector on main, tracked by NVBug 6939212, following the repository's standard waiver process. No product code changes, and no merge-blocking risk remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies an infrastructure change that waives one failed test case on the main branch.
Description check Passed The description explains the waiver, identifies the affected test files, links the associated NVBug, and states the target branch. It does not include the template's Test Coverage or PR Checklist sect…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the waiver, identifies the affected test files, links the associated NVBug, and states the target branch. It does not include the template's Test Coverage or PR Checklist sections, but the relevant change details are complete for this auto-generated waiver PR.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #78779 [ skip ] triggered by Bot. Commit: b5b16cf Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #78779 [ skip ] completed with state SUCCESS. Commit: b5b16cf
Skipping testing for commit b5b16cf

Link to invocation

@lori-ren
lori-ren merged commit e7b8fbb into NVIDIA:main Oct 19, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants