Skip to content

[https://nvbugs/6566768][test] Unwaive TestQwen3_8B::test_w4a8_mxfp4[fp8-latency] - #20558

Merged
QiJune merged 1 commit into
NVIDIA:release/1.3from
QiJune:junq/unwaive-6566768-rel1.3
Oct 19, 2026
Merged

QiJune merged 1 commit into
NVIDIA:release/1.3from
QiJune:junq/unwaive-6566768-rel1.3

Conversation

@QiJune

@QiJune QiJune commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

The change removes the waiver for TestQwen3_8B::test_w4a8_mxfp4[fp8-latency] associated with NVBUG 6566768. No source code or API behavior changes. The test is already listed in the B300 and B200 L0 CI lists and the manual QA list.

QA Engineer Review

The waiver removal restores L0 coverage for the test. The author reports that it passed during the TRT-LLM 1.3 QA cycle 1 on B300. Coverage is sufficient based on the existing CI and manual QA list entries; the reported pass was not independently verified.

Per-File QA Perspective

  • tests/integration/test_lists/waives.txt: Removes the skip entry for the test. The test remains in test-db/l0_gb300.yml, test-db/l0_b200.yml, and qa/llm_function_core.txt.

Description

Remove the release/1.3 waiver for accuracy/test_llm_api_pytorch.py::TestQwen3_8B::test_w4a8_mxfp4[fp8-latency] (https://nvbugs/6566768).

The bug has a passing record from the TRT-LLM 1.3 QA cycle 1 on B300 (2026-10-13) and is marked safe to close in the bug. While the waiver stays, L0 skips this test, so the release branch has no L0 coverage for it. This PR restores that coverage.

Test Coverage

  • accuracy/test_llm_api_pytorch.py::TestQwen3_8B::test_w4a8_mxfp4[fp8-latency]
    • pre-merge: GB300-4_GPUs-PyTorch-1 (l0_gb300.yml)
    • post-merge: DGX_B200-PyTorch-Post-Merge-1/2 (l0_b200.yml)

PR Checklist

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

🤖 Generated with Claude Code

…fp8-latency]

Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
@QiJune

QiJune commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/TensorRT-LLM/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: dacbc0e2-45ef-4209-90dd-a18c2e9e3d8e
📥 Commits

Reviewing files that changed from the base of the PR and between 9f2d5f2 and 5fd7885.

📒 Files selected for processing: 1
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes: 1
  • tests/integration/test_lists/waives.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The integration test waiver list no longer skips the Qwen3 8B W4A8 MXFP4 FP8-latency test.

Changes

Integration test waiver

Layer / File(s) Summary
Remove Qwen3 test waiver
tests/integration/test_lists/waives.txt
The skip entry for the Qwen3 8B W4A8 MXFP4 FP8-latency test was removed.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 5fd78

The Qwen3 test is restored to the test list, with no identified issue preventing merge after normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the NVBugs issue, change type, and specific test being unwaived. It is concise and directly matches the pull request changes.
Description check Passed The description explains the waiver removal, reason, reported validation, restored coverage, and relevant pre-merge and post-merge tests. It includes the required sections and checklist.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #78776 [ run ] triggered by Bot. Commit: 5fd7885 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #78776 [ run ] completed with state SUCCESS. Commit: 5fd7885
/LLM/release-1.3/L0_MergeRequest_PR pipeline #328 completed with status: 'UNSTABLE'

CI Report

⚠️ Multi-GPU Label Required:
Multi-GPU tests require the ci: full pre-merge approved label on this PR. Either:

  • Wait for the PR to be fully approved — the label is added automatically once approval is complete. Having unresolved open comments is fine, or
  • If needed, ask a member of NVIDIA/trt-llm-ci-approvers to add the label manually.
    Then re-trigger CI with the same bot command (no rebase needed).

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@QiJune

QiJune commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #78836 [ run ] triggered by Bot. Commit: 5fd7885 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #78836 [ run ] completed with state SUCCESS. Commit: 5fd7885
/LLM/release-1.3/L0_MergeRequest_PR pipeline #336 completed with status: 'SUCCESS'

CI Report

Link to invocation

@QiJune
QiJune enabled auto-merge (squash) October 19, 2026 08:17
@QiJune
QiJune merged commit d6701a1 into NVIDIA:release/1.3 Oct 19, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants