Repository navigation
[TRTLLM-14477][refactor] group multimodal request data and encoder state - #20468
Closed
yechank-nvidia wants to merge 7 commits into
Closed
yechank-nvidia wants to merge 7 commits into
yechank-nvidia wants to merge 7 commits into
Conversation
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
yechank-nvidia
force-pushed
the
refactor/mm-request-params-20261016
branch
from
October 16, 2026 09:37
63b6277 to
08c7a29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidated into #20391. Follow that PR for the combined implementation and validation.
Depends on #20391 (parent
75761fc826). Review only PR2.The parent branch is on my fork, so this draft targets upstream
mainand currently includes the parent changes. The comparison above contains only this follow-up.Description
Multimodal request data, item descriptions, encoder readiness and stream events are stored in separate places. Group them under
LlmRequest.py_multimodal_params, while keeping selected encoder inputs and LLM chunks as separate Params that do not own cache references.None; model capabilities and configuration still control scheduling. Normalize legacy order at input boundaries and keep one canonical item record in the existing payload key.MultimodalItemPartitionrecords underitem_metadata.input_partitions. Qwen supplies packed vision partitions, Gemma4 supplies image/audio fields, and Nemotron supplies standalone audio clip groups. Nemotron temporal vision, EVS and embedded video audio keep their existing model handling.Self-review found that a legacy caller adding another modality after normalization could build cache keys from incomplete item metadata. Keep that request on the existing uncacheable fallback; CUDA prefetch regression tests pass.
Validation
Revalidated after syncing both branches with
main(3ac4e61255).CPU input-preparation microbenchmark: PR1
dae1bb3a07-> PR263b62770b6, measured before the final main sync. Eight items per request, three selected; median of nine samples, twenty repetitions per sample. Request counts below describe one preparation batch, not serving concurrency.Added Python partition metadata is about 0.5 KiB per selected view; contiguous tensor selections remain views. These measurements cover CPU input preparation; serving TTFT and throughput remain unmeasured.
Full Gemma4-26B initialization did not finish in this container on the parent branch; full-weight Gemma4 parity is not claimed. Multi-GPU and AIPerf serving checks remain for the shared batching follow-up.
PR Checklist