[jiaganc]

Dev Engineer Review

Removed the two B300 MiniMaxM3 waivers for test_auto_dtype[tp_size=8-ep_size=8] and test_nvfp4[use_msa=False]. The B300 test_mxfp8[use_msa=False] waiver remains. No source or API changes were made.

QA Engineer Review

Only tests/integration/test_lists/waives.txt changed. The change enables the two targeted MiniMaxM3 accuracy selectors to run on B300. The two reported QA runs failed, with associated QA jobs marked unstable, so targeted verification remains necessary.

Coverage verdict: needs follow-up

Per-File QA Perspective

• tests/integration/test_lists/waives.txt: Removes two B300 MiniMaxM3 skip entries and keeps the B300 test_mxfp8[use_msa=False] waiver. Verify the two unwaived selectors through targeted QA; no test-db or manual-QA list changes are included.

Description

Remove the B300 waivers associated with https://nvbugs/6445375 from release/1.3 so the MiniMaxM3 BF16 TP8/EP8 and NVFP4 non-MSA accuracy cases can run when selected by QA. These exact cases previously completed QA verification successfully in #17321 (comment).

Test Coverage

• git diff --check passed.
• Targeted QA verification will be requested on this PR for:
  • accuracy/test_llm_api_pytorch.py::TestMiniMaxM3::test_auto_dtype[tp_size=8-ep_size=8]
  • accuracy/test_llm_api_pytorch.py::TestMiniMaxM3::test_nvfp4[use_msa=False]
• GPU tests have not been run locally; this PR's QA results are pending.

PR Checklist

• Description explains the change and rationale; coding guidelines reviewed.
• Existing test cases cover the change; no new code paths, APIs, dependencies, ownership, or architecture changes.
• Documentation changes are not needed for this waiver-only update.
• Reviewers assigned automatically/manually are appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

[jiaganc]

/bot run --only-qa-verify test accuracy/test_llm_api_pytorch.py::TestMiniMaxM3::test_auto_dtype[tp_size=8-ep_size=8],accuracy/test_llm_api_pytorch.py::TestMiniMaxM3::test_nvfp4[use_msa=False]

[tensorrt-cicd]

PR_Github #78110 [ run ] triggered by Bot. Commit: 3affe17 Link to invocation

[tensorrt-cicd]

PR_Github #78110 [ run ] completed with state FAILURE. Commit: 3affe17
LLM_FUNCTION_AUTO_V2C #512 completed with status: 'UNSTABLE'
QA verify test: accuracy/test_llm_api_pytorch.py::TestMiniMaxM3::test_auto_dtype[tp_size=8-ep_size=8],accuracy/test_llm_api_pytorch.py::TestMiniMaxM3::test_nvfp4[use_msa=False] (NVBug 6445375, branch codex/release-1.3-remove-6445375-waivers, fork jiaganc, dry_run_close=true)

Link to invocation

[jiaganc]

The QA pipeline failed for infra related issue. Let me run it locally.

[jiaganc]

/bot run --only-qa-verify test accuracy/test_llm_api_pytorch.py::TestMiniMaxM3::test_auto_dtype[tp_size=8-ep_size=8],accuracy/test_llm_api_pytorch.py::TestMiniMaxM3::test_nvfp4[use_msa=False]

[tensorrt-cicd]

PR_Github #78952 [ run ] triggered by Bot. Commit: 3affe17 Link to invocation

[tensorrt-cicd]

PR_Github #78952 [ run ] completed with state FAILURE. Commit: 3affe17
LLM_FUNCTION_AUTO_V2C #519 completed with status: 'UNSTABLE'
QA verify test: accuracy/test_llm_api_pytorch.py::TestMiniMaxM3::test_auto_dtype[tp_size=8-ep_size=8],accuracy/test_llm_api_pytorch.py::TestMiniMaxM3::test_nvfp4[use_msa=False] (NVBug 6445375, branch codex/release-1.3-remove-6445375-waivers, fork jiaganc, dry_run_close=true)

Link to invocation

[jiaganc]

Local test passed on GB300. I didn't find available B300 resource to run the tests, but I think this is safe enough to unwaive them.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: NVIDIA/TensorRT-LLM/.coderabbit.yaml
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 8282f47e-08d0-4c8e-8518-346403b19e4e

📥 Commits

Reviewing files that changed from the base of the PR and between 42ca6ba and 3affe17.

📒 Files selected for processing: 1

• tests/integration/test_lists/waives.txt

💤 Files with no reviewable changes: 1

• tests/integration/test_lists/waives.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

Walkthrough

Two B300 MiniMax M3 skip entries were removed from the integration test waiver list. The MXFP8 skip entry remains.

Changes

MiniMax M3 test waivers

Layer / File(s)	Summary
Update MiniMax M3 waivers tests/integration/test_lists/waives.txt	Removed skips for test_auto_dtype[tp_size=8-ep_size=8] and test_nvfp4[use_msa=False]. The test_mxfp8[use_msa=False] skip remains.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 3affe

No actionable issue is established by the waiver change. The targeted GPU tests still need the planned QA verification.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly identifies the waiver removal, the MiniMaxM3 B300 accuracy tests, and the target release branch.
Description check		The description includes the required sections, explains the change and rationale, identifies targeted tests, and records the current test status. The checklist is substantially complete for this waiv…
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description includes the required sections, explains the change and rationale, identifies targeted tests, and records the current test status. The checklist is substantially complete for this waiver-only update.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[jiaganc]

/bot skip --comment "Unwaive QA tests. Local test has passed"

[tensorrt-cicd]

PR_Github #79240 [ skip ] triggered by Bot. Commit: 3affe17 Link to invocation

[tensorrt-cicd]

PR_Github #79240 [ skip ] completed with state SUCCESS. Commit: 3affe17
Skipping testing for commit 3affe17

Link to invocation

[github-actions]

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.