fix(cli): classifyGatewayStatus no longer misclassifies "Not connected"

[cv]

Summary

The classifyGatewayStatus regex matched "Not connected" as connected because \bConnected\b matches the substring. This was partially fixed in #1268 (added Disconnected guard) but "Not connected" still slipped through.

Fix:

• Move unavailable-pattern check before connected check
• Use strict line-anchored regex: /^\s*(?:Status:\s*)?Connected\s*$/im
• Add regression tests for "Status: Not connected" → inactive

This fix was intended for #1268 but the auto-merge squashed before the commit landed.

Fixes #1279.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes

  • Improved gateway connection status detection to handle edge cases and properly classify various status formats, ensuring more accurate connection state reporting.

• Tests

  • Added test coverage for additional gateway status variations.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0cc5b4fe-0727-4c50-83bf-264bbe431579

📥 Commits

Reviewing files that changed from the base of the PR and between c3fd887 and 9ff4d10.

📒 Files selected for processing (2)

• src/lib/runtime-recovery.test.ts
• src/lib/runtime-recovery.ts

---

📝 Walkthrough

Walkthrough

The changes fix a bug where gateway status strings containing "Not connected" were misclassified as "connected". The regex pattern for detecting a connected state is now stricter, requiring the word "Connected" to appear alone (optionally prefixed with "Status:") rather than as part of a larger phrase, with corresponding test coverage.

Changes

Cohort / File(s)	Summary
Gateway Status Classification Bug Fix src/lib/runtime-recovery.ts, src/lib/runtime-recovery.test.ts	Updated classifyGatewayStatus to use stricter regex /^\s*(?:Status:\s*)?Connected\s*$/im that matches only when "Connected" appears alone (not within "Not connected"). Added regression test cases for "Status: Not connected" → "inactive" and "Connected" → "connected".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A gateway once fibbed 'bout its health and state,
"Not connected" pretended it was great!
A rabbit fixed the regex, precise and clean,
Now true is true, and false is clearly seen! 🐰

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely summarizes the main fix: preventing misclassification of 'Not connected' by the classifyGatewayStatus function.
Linked Issues check	✅ Passed	The PR successfully implements all objectives from issue #1279: stricter connected regex, unavailable check priority, and regression tests for edge cases.
Out of Scope Changes check	✅ Passed	All changes are directly related to fixing the classifyGatewayStatus function and adding regression tests, with no unrelated modifications present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cv/fix-classify-gateway-not-connected

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ericksoa]

Clean fix for #1279. LGTM.