-
Notifications
You must be signed in to change notification settings - Fork 315
feat(install): slim install for remote/NIM-only inference on Intel Mac #1830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
charlesbluca
wants to merge
26
commits into
NVIDIA:main
Choose a base branch
from
charlesbluca:slim-install
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
0ef1eae
Add workflow_dispatch integration test for library mode on Windows an…
charlesbluca 6a21df3
Split torch cu130 deps into explicit group
charlesbluca bbe51d3
ci: increase RAY_raylet_start_wait_time_s for macOS integration tests
charlesbluca 027c154
Use inprocess run mode for now
charlesbluca 79e8f0b
Pass API key via --api-key flag using NGC_NV_DEVELOPER_NVCF secret
charlesbluca 1f31946
Initial plan & refactors for slimmer instal
charlesbluca 8c45923
Drop nv-ingest as dep
charlesbluca 531015e
Make heavy optional deps lazy for slim Intel Mac install
charlesbluca 6190f04
Fix Intel Mac slim-install blockers in PDF/image/embed pipeline
charlesbluca 264ab24
Merge remote-tracking branch 'upstream/main' into slim-install
charlesbluca fd53df6
Use CUDA torch index for Windows as well as Linux
charlesbluca 5bef6f7
Merge branch 'slim-install'
charlesbluca 26475c8
Add macOS x64 to workflow
charlesbluca 4b120f0
torch cuda index rename
charlesbluca 9f2035b
Merge branch 'slim-install'
charlesbluca 45f2732
Try switching to macos-26-intel
charlesbluca 9e01344
Modify unit test install
charlesbluca 326de9a
Linting
charlesbluca 0722e6f
Guard optional imports and restore graceful embedding failure handling
charlesbluca 4591f62
Fix test failures from lazy import change and network-dependent token…
charlesbluca 4273b5a
Fix misplaced docstrings and remove invalid uv conflicts block
charlesbluca 25622df
Simplify dependency groups; move remote and lancedb to core
charlesbluca 48a8953
Drop agent doc
charlesbluca 03dc39f
Fix README install instructions to reflect simplified dependency groups
charlesbluca ec99f30
ci: add nightly schedule trigger and fix secret name in library mode …
charlesbluca 92f777a
Compat code for ray[data] 2.49
charlesbluca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2024-25, NVIDIA CORPORATION & AFFILIATES. | ||
| # All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| name: Library Mode Integration Tests (Windows & macOS) | ||
|
|
||
| on: | ||
| schedule: | ||
| # Runs every day at 11:30PM (UTC) | ||
| - cron: "30 23 * * *" | ||
| workflow_dispatch: | ||
| inputs: | ||
| source-ref: | ||
| description: 'Git ref to test (branch, tag, or SHA). Defaults to the dispatched branch.' | ||
| required: false | ||
| type: string | ||
| default: '' | ||
|
|
||
| jobs: | ||
| integration-test: | ||
| name: Integration Tests (${{ matrix.os-label }}) | ||
| runs-on: ${{ matrix.runner }} | ||
| timeout-minutes: 90 | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - runner: windows-latest | ||
| os-label: windows-x64 | ||
| - runner: macos-26 | ||
| os-label: macos-arm64 | ||
| - runner: macos-26-intel | ||
| os-label: macos-x64 | ||
|
|
||
| env: | ||
| # NIM endpoint URLs — edit these directly to point at different deployments | ||
| PAGE_ELEMENTS_INVOKE_URL: "https://ai.api.nvidia.com/v1/cv/nvidia/nemotron-page-elements-v3" | ||
| OCR_INVOKE_URL: "https://ai.api.nvidia.com/v1/cv/nvidia/nemoretriever-ocr-v1" | ||
| GRAPHIC_ELEMENTS_INVOKE_URL: "https://ai.api.nvidia.com/v1/cv/nvidia/nemotron-graphic-elements-v1" | ||
| TABLE_STRUCTURE_INVOKE_URL: "https://ai.api.nvidia.com/v1/cv/nvidia/nemotron-table-structure-v1" | ||
| EMBED_INVOKE_URL: "https://integrate.api.nvidia.com/v1" | ||
| EMBED_MODEL_NAME: "nvidia/llama-nemotron-embed-1b-v2" | ||
|
|
||
| steps: | ||
| - name: Check out repository code | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ inputs.source-ref != '' && inputs.source-ref || github.ref }} | ||
|
|
||
| - name: Set up Python 3.12 | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.12' | ||
|
|
||
| - name: Install uv | ||
| run: pip install uv | ||
|
|
||
| - name: Install nemo-retriever and dependencies | ||
charlesbluca marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| shell: bash | ||
| run: | | ||
| uv pip install --system -e "nemo_retriever" | ||
|
|
||
| - name: Run graph pipeline on PDFs | ||
| shell: bash | ||
| env: | ||
| PYTHONPATH: nemo_retriever/src | ||
| run: | | ||
| python -m nemo_retriever.examples.graph_pipeline ./data \ | ||
| --run-mode inprocess \ | ||
| --input-type pdf \ | ||
| --api-key "${{ secrets.NVCF_API_KEY }}" \ | ||
| --page-elements-invoke-url "$PAGE_ELEMENTS_INVOKE_URL" \ | ||
| --ocr-invoke-url "$OCR_INVOKE_URL" \ | ||
| --use-graphic-elements \ | ||
| --graphic-elements-invoke-url "$GRAPHIC_ELEMENTS_INVOKE_URL" \ | ||
| --use-table-structure \ | ||
| --table-structure-invoke-url "$TABLE_STRUCTURE_INVOKE_URL" \ | ||
| --embed-invoke-url "$EMBED_INVOKE_URL" \ | ||
| --embed-model-name "$EMBED_MODEL_NAME" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both
actions/checkout@v4andactions/setup-python@v5use mutable version tags. Per the repository'sgithub-actions-securityrule, third-party actions must be pinned to a full commit SHA to prevent supply-chain attacks.Prompt To Fix With AI