Skip to content

Respect the user-provided log options regardless of tracing configuration #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

RobGeada
Copy link

Description

Using tracing overrides all user-provided logging configuration. While this is necessary to generate detailed logs, it should not require returning that new log information back to the user if they did not request it. See #1316 for more detail.

Changes:

  1. Ensures that regardless of tracing configuration, the returned response object respects the requested log options.
  2. Modifies existing tracing unit test to account for new logging behavior
  3. Adds new tracing unit test to check that ll permutations of logging options are respected if tracing is configured.

Related Issue(s)

Checklist

  • I've read the CONTRIBUTING guidelines.
  • I've updated the documentation if applicable.
  • I've added tests if applicable.
  • @mentions of the person or team responsible for reviewing proposed changes.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.47%. Comparing base (bee719b) to head (9c290a1).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1317      +/-   ##
===========================================
+ Coverage    70.45%   70.47%   +0.02%     
===========================================
  Files          161      161              
  Lines        16214    16225      +11     
===========================================
+ Hits         11423    11434      +11     
  Misses        4791     4791              
Flag Coverage Δ
python 70.47% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
nemoguardrails/rails/llm/llmrails.py 89.61% <100.00%> (+0.17%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants