feat(redis): add redis memory backend and redis memory example #376 #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#376 Signed-off-by: Brian Caffey <[email protected]>
mdemoret-nv
added
feature request
mdemoret-nv
requested changes
Jun 18, 2025
Comment on lines
+83
to
+92
| logger.info("Computing embedding for memory text") | ||
| search_vector = self._embedder.embed_query(memory_text) | ||
| logger.info(f"Generated embedding vector of length: {len(search_vector)}") | ||
| memory_data["embedding"] = search_vector | ||
|
|
||
| try: | ||
| # Store as JSON in Redis | ||
| logger.info(f"Attempting to store memory data in Redis for key: {memory_key}") | ||
| await self._client.json().set(memory_key, "$", memory_data) | ||
| logger.info(f"Successfully stored memory data for key: {memory_key}") |
There was a problem hiding this comment.
This is a large number of logging statements to be printed each time at the INFO level. Can we change these to logger.debug()?
There was a problem hiding this comment.
This should be applied consistently throughout the entire file
|
|
||
| self._client = redis_client | ||
| self._key_prefix = key_prefix | ||
| self._embedder = embedder |
There was a problem hiding this comment.
Check for None values for redis_client and embedder. The checks later on in the file for if self._embedder: can then be removed.
| @@ -38,6 +38,7 @@ llms: | |||
| nim_llm: | |||
| _type: nim | |||
| model_name: meta/llama-3.3-70b-instruct | |||
| # base_url: http://192.168.5.173:8000/v1 | |||
There was a problem hiding this comment.
Was this intentional? Can it be removed?
|
/ok to test 7ead134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #376
By Submitting this PR I confirm: