-
Notifications
You must be signed in to change notification settings - Fork 218
[5336829][AutoCast] Support subgraphs #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/bot run |
a238cc4 to
965b1ec
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
=======================================
Coverage 74.72% 74.73%
=======================================
Files 192 192
Lines 18833 18872 +39
=======================================
+ Hits 14073 14104 +31
- Misses 4760 4768 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gcunhase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
Should we update the Changelog for this? Up to you if you think it's major enough, thanks. |
965b1ec to
11b94b1
Compare
Initial bug mentioned conditional operators, but the issue can be generalized to any subgraph in the ONNX. Support by recursively traversing subgraphs in PrecisionConverter. Signed-off-by: Gal Hubara Agam <[email protected]>
11b94b1 to
dffbd43
Compare
Signed-off-by: Keval Morabia <[email protected]>
Initial bug mentioned conditional operators, but the issue can be generalized to any subgraph in the ONNX. Support by recursively traversing subgraphs in PrecisionConverter.
What does this PR do?
Type of change: ? Bug fix
Overview:
Initial bug mentioned conditional operators, but the issue can be generalized to any subgraph in the ONNX.
Support by recursively traversing subgraphs in PrecisionConverter.
Testing
Add unit tests with conditional
tests/unit/onnx/autocast/test_precisionconverter.py::model_with_if_subgraph
tests/unit/onnx/autocast/test_precisionconverter.py::test_if_subgraph_initializer_conversion
tests/unit/onnx/autocast/test_precisionconverter.py::test_if_subgraph_mixed_precision_boundary
Before your PR is "Ready for review"
Additional Information