Skip to content

fix: report ASR model type instead of name in unknown type error - #15948

Open
andrewwhitecdw wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
andrewwhitecdw:fix-eval-generated-audio-error-msg
Open

fix: report ASR model type instead of name in unknown type error#15948
andrewwhitecdw wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
andrewwhitecdw:fix-eval-generated-audio-error-msg

Conversation

@andrewwhitecdw

Copy link
Copy Markdown
Contributor

When load_evaluation_models receives an unsupported asr_model_type, the error message was printing the model name/path instead of the invalid type, making debugging harder.

  • Fixed the interpolation in nemo/collections/tts/modules/magpietts_inference/evaluate_generated_audio.py
  • Added a unit test verifying the error message contains the invalid type value

Tested:

uv run python -m pytest tests/collections/tts/modules/magpietts_inference/test_evaluate_generated_audio.py -v
# 1 passed

cc @blisc for TTS review

Signed-off-by: Andrew White <andrewh@cdw.com>
@copy-pr-bot

copy-pr-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added the waiting-on-maintainers Waiting on maintainers to respond label Jul 26, 2026
@andrewwhitecdw

Copy link
Copy Markdown
Contributor Author

Could a maintainer please add the Run CICD label to trigger CI? As an outside contributor I don't have permission to apply labels myself. Thanks!

@svcnvidia-nemo-ci svcnvidia-nemo-ci added waiting-on-maintainers Waiting on maintainers to respond and removed waiting-on-maintainers Waiting on maintainers to respond labels Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-request TTS waiting-on-maintainers Waiting on maintainers to respond

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants