Repository navigation
fix(cc): retain sealed selections across infrastructure retries - #4628
Open
Epsilon006 wants to merge 1 commit into
Open
Epsilon006 wants to merge 1 commit into
Epsilon006 wants to merge 1 commit into
Conversation
aroshanghias-nvd
force-pushed
the
aroshanghias/cc-capture-redesign-20260914
branch
from
October 13, 2026 22:46
41f2622 to
dae5a4a
Compare
Signed-off-by: Epsilon006 <199138677+Epsilon006@users.noreply.github.com>
Epsilon006
force-pushed
the
fix/4557-cc-infra-retry
branch
from
October 18, 2026 07:13
2898a6e to
1f01a10
Compare
Author
|
@terrykong — this PR addresses #4557 and is stacked on #4124. Could you advise on the next validation step and help route the NVIDIA runner vetting request to the appropriate maintainer? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transient forest-training rollout failures drop the prompt group on the first infrastructure error despite a larger retry budget. Retain selections for sealed siblings across live retries, discard abandoned selections, and honor the existing budget and backoff. Prompt-group recovery reruns the abandoned cohort; sibling recovery reruns only missing siblings.
Closes #4557. Stacked on #4124; the target remains
aroshanghias/cc-capture-redesign-20260914.This PR is now a single signed-off commit based directly on the #4124 foundation head (
2f3649d75bbe85724984a49fb6a2da575777a157). The diff against that foundation changes only the retry logic, tests, and documentation (4 files, +339/-15); no dependency, lockfile, or Gym pin changes.Validation
SimpleNamespace.timeout) reproduce on the unmodified foundation.returned_historyandall_capturedpass the regression: complete owners and all four rows reach the controller train pump with exact tokens and logical GRPO advantages.Tests ran in an isolated Linux Docker container with Python 3.13.14, CPU torch 2.13.0, Lens
b0f977d4, and Gym infrastructure #4128 (b53e7b7e) combined locally with the native client from #3368 (507d15c3). CPU tests exclude repository-wide Ray cluster/monitor fixtures and use generation, storage and learner doubles. No GPU training or full distributed qualification is claimed. Final paired-dependency integration and NVIDIA runner approval remain maintainer gates.Live retries can repeat external agent side effects. Forest-training checkpoint/resume remains unsupported; an exhausted group still prevents a complete training step.
Hosted checks and remaining gates
For the current head
1f01a10f008e14f1aece46c36709ed2434e4d5ca, DCO has passed, and the lightweight semantic PR-title, triage, and submodule-comment checks have passed. Other hosted workflow runs still reportaction_required; NVIDIA runner vetting and approval to run heavyweight CI remain outstanding. GPU training and full distributed validation have not been completed. This PR remains stacked on and dependent on the unmerged #4124 foundation. Final paired-dependency integration and maintainer approval remain merge gates.