Repository navigation
Split retrieval queries by generic groups over a shared corpus - #91
Closed
shan-nvidia wants to merge 1 commit into
Closed
shan-nvidia wants to merge 1 commit into
shan-nvidia wants to merge 1 commit into
Conversation
shan-nvidia
requested review from
a team and
oliverholworthy
as code owners
September 19, 2026 01:15
This was referenced Sep 19, 2026
Collaborator
Author
|
Superseded by the consolidated generic multimodal SDG EA candidate in #92, with recipe integration in NVIDIA-NeMo/Nemotron#359. Generic grouping/export work is retained there. Closing the duplicate proposal only: this branch and commit history are preserved for existing pinned consumers. No running experiment is migrated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Stacked on #89. Make grouped query-disjoint splitting over a shared full corpus the portable retrieval export protocol.
Why
In-domain adaptation retrieves new queries against the customer's existing collection. Document overlap is intentional; known query rewrites must stay together. This new feature does not retain document-disjoint export compatibility.
Usage
Optionally attach
query_provenancekeyed by final candidate index, e.g.{"0": {"query_group_id": "warranty", "seed_query_id": "seed-42"}}. Parent query IDs are supported too. Missing provenance produces singleton groups joined by normalized duplicates. Lexical near-duplicate grouping is opt-in withgroup_near_duplicates=True; unknown semantic equivalents cannot be guaranteed detectable.How
Resolve explicit groups, derivations and normalized duplicates before splitting. Assign groups once across export views. Do not group independent queries merely because they share a document, page, summary or context. Retain existing acceptance gates unchanged. Each view uses a shared full eligible corpus, including distractors; training/evaluation query assignments remain disjoint. No dataset-specific adapters or new VLM defaults. Paired consumer: NVIDIA-NeMo/Nemotron#353.
Validation
make sync,make format,make all: passed (lint, all isolated plugin tests, validation, metadata checks, strict docs).No changes were deployed to ongoing experiment workers or their frozen input/config/source snapshots.