Skip to content

fix: DataDesigner guard lambda rejects positional arguments - #69

Merged
oliverholworthy merged 1 commit into
NVIDIA-NeMo:mainfrom
andrewwhitecdw:bugfix/test-generation-datadesigner-guard-lambda-rejects
Aug 18, 2026
Merged

oliverholworthy merged 1 commit into
NVIDIA-NeMo:mainfrom
andrewwhitecdw:bugfix/test-generation-datadesigner-guard-lambda-rejects

Conversation

@andrewwhitecdw

Copy link
Copy Markdown
Contributor

This PR addresses the following issue in plugins/data-designer-retrieval-sdg/tests/test_generation.py: DataDesigner guard lambda rejects positional arguments.

Changes

  • plugins/data-designer-retrieval-sdg/tests/test_generation.py: DataDesigner guard lambda rejects positional arguments.

Details

--- a/plugins/data-designer-retrieval-sdg/tests/test_generation.py
+++ b/plugins/data-designer-retrieval-sdg/tests/test_generation.py
@@ -1,5 +1,5 @@
-    monkeypatch.setattr(
-        generation,
-        "DataDesigner",
-        lambda **_: pytest.fail("DataDesigner must not be constructed before output directory validation"),
-    )
+    monkeypatch.setattr(
+        generation,
+        "DataDesigner",
+        lambda *args, **kwargs: pytest.fail("DataDesigner must not be constructed before output directory validation"),
+    )

Tests

Let me know if you want tests added for this fix or not.

Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>

@oliverholworthy oliverholworthy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tightening this.

@oliverholworthy
oliverholworthy merged commit c770eb2 into NVIDIA-NeMo:main Aug 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants