Repository navigation
Allow multimodal SDG to skip exhausted validation failures - #100
Merged
Merged
Conversation
oliverholworthy
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add opt-in
failed_record_policy: skipto multimodal retrieval SDG and theretrieval-structuredcolumn. A permanently malformed model response becomes a recorded failure after the existing native validation retries, allowing usable records to reach export. The default remainserror.Why
Currently one persistently invalid response can prevent an entire run from exporting, even though other responses are already cached. Explicit resume preserves the good work but can repeatedly fail on the same record. Operators need a way to continue while accounting for those failures.
Usage
Add this to a new run's existing multimodal YAML configuration:
For example, if one context's query generation exhausts validation retries, its requested slots are recorded as failed and the other contexts continue through the existing quality gates. A failed required judgment or localization excludes the affected query. Original corpus units remain available.
Inspect
generation_failures.jsonin the run directory and portable bundle, andreport.json.generation_failuresfor counts by stage, failed requested slots, and excluded query IDs. Failed slots are separate from abstentions and quality rejections.Generated queries remain in
funnel.generatedand the retention denominator if a later judgment or localization fails. Three generated queries with two accepted and one localization failure report three generated and2/3retention. Multiple failed judgments for the same query count once. Direct structured-column users receiveNonein configured trace and reasoning columns for failed records, allowing downstream expressions to handle even an entirely failed batch.Omit the option, or use
error, for strict behavior. Changing policy or implementation requires a new output directory because ordinary resume checks the frozen run identity.How
ModelGenerationValidationFailureErrorafter Data Designer's existing native retry budget. Other errors and unexplained missing/duplicate identities remain errors.missing_response_attemptsretains its existing separate meaning.Validation
make allpassed: Ruff lint/format, isolated tests for every plugin, plugin validation, generated metadata and license checks, and the strict documentation build.make plugin-docsregenerated the documentation;git diff --checkpassed.Linked Issue
Repository collaborator performing a focused maintenance fix.