Skip to content

Explicitly restrict checkpoint loading #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjomier merged 2 commits into from
Sep 22, 2026
Merged

Explicitly restrict checkpoint loading #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f540f99
Explicitly restrict checkpoint loading to weights-only state
waltsims Sep 22, 2026
192cec8
Remove checkpoint regression tests
waltsims Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion utils/training.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ def save_checkpoint(state: dict[str, Any], run: RunPaths, *, name: str = "last.c


def load_checkpoint(path: Path | str) -> dict[str, Any]:
return torch.load(Path(path), map_location="cpu")
"""Load tensor and primitive checkpoint state without arbitrary pickle objects."""
return torch.load(Path(path), map_location="cpu", weights_only=True)

@greptile-apps greptile-apps Bot Sep 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Checkpoint Tests Are Missing

The new weights_only=True restriction has no committed regression coverage, despite the PR description stating that tests were added. Please add tests showing that tensor and primitive checkpoints still round-trip and that unsupported pickle objects are rejected; otherwise, this security-sensitive behavior could silently regress.



def save_config_snapshot(run: RunPaths, cfg: dict[str, Any], *, name: str = "config.yaml", overwrite: bool = False) -> Path:
Expand Down
Loading