Add conformer RMSD docs and fix MMFF benchmark build after API change#126
Merged
evasnow1992 merged 1 commit intoNVIDIA-Digital-Bio:mainfrom Apr 2, 2026
Merged
Conversation
Add conformer RMSD to feature list (docs/index.rst) and API reference (docs/api/nvmolkit.rst) — missing since PR NVIDIA-Digital-Bio#105. Fix mmff_multimol_bench.cpp build error: MMFFOptimizeMoleculesConfsBfgs now takes MMFFProperties instead of raw nonBondedThreshold (changed in PR NVIDIA-Digital-Bio#116).
Contributor
|
| Filename | Overview |
|---|---|
| benchmarks/mmff_multimol_bench.cpp | Adapts the BFGS benchmark call to pass MMFFProperties struct instead of a raw nonBondedThreshold float, matching the API change from PR #116. Correct fix — value preserved (100.0), no other logic changed. |
| docs/api/nvmolkit.rst | Adds a "Conformer RMSD" autosummary section listing GetConformerRMSMatrix and GetConformerRMSMatrixBatch. Both names match the actual module's all and public API exactly. |
| docs/index.rst | Adds a one-line Conformer RMSD bullet to the feature list, consistent in style with the surrounding entries. |
Reviews (1): Last reviewed commit: "Add conformer RMSD docs and fix MMFF ben..." | Re-trigger Greptile
scal444
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add conformer RMSD to feature list (docs/index.rst) and API reference (docs/api/nvmolkit.rst) — missing since PR #105.
Fix mmff_multimol_bench.cpp build error: MMFFOptimizeMoleculesConfsBfgs now takes MMFFProperties instead of raw nonBondedThreshold (changed in PR #116).