Auto format copyright and add linter#121
Conversation
|
| Filename | Overview |
|---|---|
| admin/apply_copyright.sh | Major refactor: adds check-only mode, dynamic year detection via git history, and per-language header functions. Still carries unresolved issues from prior review rounds: hardcoded 2026 ceiling in get_file_year, admin/ directory excluded from find_included_files, write_header uses mv without restoring file permissions, and the shebang path generates a double-blank separator for scripts with blank lines after the shebang. |
| .github/workflows/lint.yml | New copyright-check CI job added. Correctly uses fetch-depth: 0 so git-log year detection has full history; runs apply_copyright.sh -d in check-only mode. Since admin/ is excluded by find_included_files, the CI will not catch missing/wrong headers in admin scripts. |
| admin/distribute/verify_conda_distributable.sh | Copyright header added and mode changed from 100755 to 100644 (execute bit lost); header is missing the blank-line separator between the license block and set -exuo pipefail. |
| admin/distribute/verify_conda_version_combinations.sh | Same as verify_conda_distributable.sh: execute bit dropped (100755 → 100644) and blank-line separator after the license header is missing. |
| benchmarks/updateInverseHessianBench.cu | Copyright header added with correct 2025 year and proper blank-line separator before the first #include; no functional changes. |
| tests/test_openmp_helpers.cpp | Non-SPDX copyright line replaced with full SPDX-compliant header; blank-line separator present before #include; file compiles correctly. |
Reviews (4): Last reviewed commit: "Fix more copyrights" | Re-trigger Greptile
evasnow1992
left a comment
There was a problem hiding this comment.
Changes look good to me.
No description provided.