deleted settings panel, move logical to use popover#171
deleted settings panel, move logical to use popover#171DinaLaptii wants to merge 2 commits intoNVIDIA-AI-Blueprints:developfrom
Conversation
Greptile SummaryThis PR deletes the standalone
Confidence Score: 5/5Safe to merge; all remaining findings are minor cleanup items (P2) that do not affect runtime behaviour. The core functionality is correctly migrated — theme control was already wired to providers.tsx which reads from the layout store and applies CSS classes to the document. Tests are updated. The two remaining items (stale RightPanelType union member, orphaned SettingsPanel files) are non-blocking style/cleanup issues. frontends/ui/src/features/layout/types.ts (stale 'settings' in RightPanelType) and the undeleted SettingsPanel.tsx / SettingsPanel.spec.tsx files. Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant AppBar
participant Popover
participant AppearanceThemeControl
participant LayoutStore
participant ThemeProvider
User->>AppBar: Click avatar button
AppBar->>Popover: Open user dropdown
Popover->>AppearanceThemeControl: Render theme segments (System/Dark/Light)
User->>AppearanceThemeControl: Click Dark / Light / System
AppearanceThemeControl->>LayoutStore: setTheme(mode)
LayoutStore-->>ThemeProvider: theme state update (via useLayoutStore)
ThemeProvider->>ThemeProvider: Apply nv-dark / nv-light class to document root
Reviews (2): Last reviewed commit: "fix tests" | Re-trigger Greptile |
I think we need a feature toggle for these changes. I have updated the design according to the Figma:
https://www.figma.com/design/JHtiVv7hEmntIYISMcoQJP/AI-Q-3.0--Nvidia-Agent-Space-?node-id=139-7444&t=UdqFIqYeUipeSgRe-0