default state of data sources side panel is open#165
default state of data sources side panel is open#165DinaLaptii wants to merge 5 commits intoNVIDIA-AI-Blueprints:developfrom
Conversation
Greptile SummaryThis PR changes the default state of the data sources side panel from closed ( Confidence Score: 5/5Safe to merge — changes are minimal, internally consistent, and all tests updated correctly. All five files agree on the new default behavior. The store's initial state, its action implementations, the type declarations, and both spec files are fully consistent. No logic errors, type mismatches, or missing updates were found. The previously flagged disableNonWebSources/disableEciSources mismatch does not exist in the current code. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant MainLayout
participant useLayoutStore
Note over useLayoutStore: Initial state: rightPanel = 'data-sources'
User->>MainLayout: Click "New Session"
MainLayout->>useLayoutStore: startNewSessionDraft()
MainLayout->>useLayoutStore: clearSessionUrl()
MainLayout->>useLayoutStore: openRightPanel('data-sources')
useLayoutStore-->>MainLayout: rightPanel = 'data-sources'
MainLayout-->>User: Data Sources panel stays visible
Reviews (4): Last reviewed commit: "revert naming" | Re-trigger Greptile |
| disableEciSources: () => | ||
| set( | ||
| (state) => ({ | ||
| enabledDataSourceIds: state.enabledDataSourceIds.filter( | ||
| (id) => id === WEB_SEARCH_SOURCE_ID | ||
| ), | ||
| }), | ||
| false, | ||
| 'disableNonWebSources' | ||
| 'disableEciSources' | ||
| ), |
There was a problem hiding this comment.
types.ts not updated to match renamed action
disableNonWebSources was renamed to disableEciSources in store.ts, but types.ts line 79 still declares disableNonWebSources: () => void in the LayoutActions interface. Because the store is typed as create<LayoutStore>() where LayoutStore = LayoutState & LayoutActions, TypeScript will report a compile error: the store object is missing the required disableNonWebSources method.
Update types.ts to reflect the rename:
// types.ts, line 78-79
/** Disable all ECI (non-web) sources (keep only web_search enabled) */
disableEciSources: () => void|
TBH I would wait on this PR since we are working on a more holistic design to fix this issue. |
I need to add the feature toggle logic for the new UI from another pr