fix: OpenAPI Swagger docs generation in certain scenarios #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namely when paths have no validation errors so there are no components, or in the same situation when a security scheme is used that creates a components without the necessary schemas key
ajstewart
changed the title
Contributor
Author
|
@EdgyEdgemond this fixes it for me in the above scenarios, though wasn't sure if there could be some pitfalls here that I haven't thought of. |
Contributor
|
Thanks for the PR, looks sound. Cant see any pitfalls. just scenarios I hadn't discovered or thought to test for :) |
Contributor
Author
|
Whoops I forgot to run the pre-commit, have added an ignore to that test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the generation of the OpenAPI swagger docs in the following scenarios:
Fixes #44