Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.11 and 3.12 versions to testing matrix #428

Open
wants to merge 43 commits into
base: aggregated_filters_for_trials
Choose a base branch
from

Conversation

martin-springer
Copy link
Collaborator

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (131bd43) to head (3b1d6ad).
Report is 4 commits behind head on aggregated_filters_for_trials.

Additional details and impacted files
@@                        Coverage Diff                        @@
##           aggregated_filters_for_trials     #428      +/-   ##
=================================================================
+ Coverage                          96.09%   96.10%   +0.01%     
=================================================================
  Files                                 11       11              
  Lines                               2200     2207       +7     
=================================================================
+ Hits                                2114     2121       +7     
  Misses                                86       86              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from new_default_behavior to aggregated_filters_for_trials August 21, 2024 15:11
@martin-springer
Copy link
Collaborator Author

@mdeceglie - Regarding numpy > 2. We would need pandas 2.2.2 (https://pandas.pydata.org/docs/whatsnew/v2.2.2.html). However, the bug you found in pandas is still persistent in 2.2.2 (pandas-dev/pandas#55794).

Not sure, how to proceed...

@mdeceglie
Copy link
Collaborator

mdeceglie commented Sep 6, 2024

Good catch @martin-springer the only place I can find where that bug comes into play is in get_clearsky_tamb() where the frequency of a series gets checked twice, once on the whole thing and again on the first 10 elements if the first try fails. Updating to pandas 2.2.2 sure enough caused an error associated with the pandas bug in our testing of that function. I updated get_clearsky_tamb() with @kandersolar's work around and that seems to work. (Also fixing another testing error that cropped up)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants