set high soc default to 1

[paulf81]

The controller BatteryPriceSOCController uses high_soc and low_soc to determine if charging/discharging should happen or if should wait for higher/lower prices. Experience with demonstrations shows while the low_soc being used (set for example to 0.2) adds value, effectively disabling high_soc by setting to 1.0 is the better setting. This makes some sense in that RT LMPs can feature very high price spikes, but on the low end their is often a pretty clear floor in-between 0 and $-26. Waiting to charge for very low prices does not seem to pay off given this asymmetric skew in prices.

This PR sets the default values accordingly and updates the docstring.

[Copilot]

Pull request overview

This PR updates the default high_soc parameter from 0.8 to 1.0 in the BatteryPriceSOCController, effectively disabling the high SOC threshold by default. This change is based on empirical evidence showing that waiting for very low prices to charge is not cost-effective, while waiting for high prices to discharge (controlled by low_soc) remains valuable due to asymmetric price distributions in real-time LMPs.

Key changes:

• Changed default high_soc parameter from 0.8 to 1.0
• Updated docstring to reflect corrected behavior description and new defaults
• Added explanatory note about the rationale for these default values

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Corrected spelling of 'effictively' to 'effectively'.

Suggested change

	Note high_soc defaults to 1.0 (effictively disabled) since experience suggests waiting for
	Note high_soc defaults to 1.0 (effectively disabled) since experience suggests waiting for

[paulf81]

fixed

[misi9170]

Thanks @paulf81 . I made a very minor formatting change to the docstring and will merge once checks clear.