Fix startup routine to add gearbox ratio to calculations

[abhineet-gupta]

Description and Purpose

Fix startup routine to add gearbox ratio to calculations

Type of change

What types of change is it?

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (non-backwards-compatible fix or feature)
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Documentation update
• Maintenance update
• Other (please describe)

TODO Items General:

• Add example/test for new feature
• Update registry
• Run testing

TODO Items API Change:

• Update docs with API change
• Run update_rosco_discons.py in Test_Cases/
• Update DISCON schema

Github issues addressed, if one exists

Addresses #488

Examples/Testing, if applicable

N/A

[dzalkind]

Should this be CntrPar%SU_RotorSpeedThresh * CntrPar%WE_GearboxRatio / CntrPar%PC_RefSpd

PC_RefSpd is a generator value.

[abhineet-gupta]

Yes,
I think fortran calculates CntrPar%SU_RotorSpeedThresh / CntrPar%PC_RefSpd * CntrPar%WE_GearboxRatio same as CntrPar%SU_RotorSpeedThresh * CntrPar%WE_GearboxRatio / CntrPar%PC_RefSpd (unless I am mistaken).
I'll push a fix based on your suggestion as it is better for readability anyways.

[dzalkind]

Ah, you might be correct. Have you tested this on a geared system?

[abhineet-gupta]

I tested it with NREL-5MW with two load staged of 0.2 and 1:

Seem to be working.

[abhineet-gupta]

Looked into why regression test is failing.
Example 11_robust_tuning.py fails becuase "self.controller.Kp_float" is a 1-d numpy array which causes error when using numpy=2.4.1 (current) here:

ROSCO/rosco/toolbox/utilities.py

Line 773 in fc11f43

y = float(x)

.
The example runs fine with numpy=1.26.4.

[dzalkind]

Thanks!! I've seen similar errors over in WEIS. I can fix this to work with new versions of numpy that are now being used.